From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 089A18CAA5 for ; Fri, 4 Nov 2022 10:56:15 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DC030D0F for ; Fri, 4 Nov 2022 10:56:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 4 Nov 2022 10:56:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C8A7044C7E for ; Fri, 4 Nov 2022 10:56:13 +0100 (CET) Message-ID: <67635e63-d26b-ceb8-a8c0-2db5cedc4c52@proxmox.com> Date: Fri, 4 Nov 2022 10:56:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 To: Proxmox VE development discussion , Daniel Tschlatscher References: <20221104091847.60112-1-d.tschlatscher@proxmox.com> Content-Language: en-GB From: Thomas Lamprecht In-Reply-To: <20221104091847.60112-1-d.tschlatscher@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.034 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: [pve-devel] applied: [PATCH manager] gui: fix firewall security group help button chapter link X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Nov 2022 09:56:15 -0000 Am 04/11/2022 um 10:18 schrieb Daniel Tschlatscher: > The help button under Datacenter > Firewall > Security Group did not > have the proper help chapter link set. > > First reported here: > https://forum.proxmox.com/threads/broken-help-link-in-proxmox-gui.117503/ > > Signed-off-by: Daniel Tschlatscher > --- > I noticed that the onlineHelp field for our custom classes is > sometimes defined outside of the class, in the Config which defines > the layout of the navigation panel, and sometimes inside of the class > directly. > This time I added it inside the class, as it seems to be the more > commonly used thing. Though, is there any preference for this? > meh, not using the class itself directly is mostly relevant for components where there's either a different docs for different usages, albeit a) that is really rare and b) that can be overridden too. So no, basically no difference, and personally I'd say that declaring it in the class itself keeps related information better together and visible, and thus easier to keep in sync. The usage declaration in the Config modules should mostly have properties declared that are relevant for the navigation/tab bar itself, not the panel that gets shown if the menu/tab entry is actually selected. > > www/manager6/dc/SecurityGroups.js | 1 + > 1 file changed, 1 insertion(+) > > applied, thanks!