From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7C19F8DB0D for ; Wed, 9 Nov 2022 14:11:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 558991C668 for ; Wed, 9 Nov 2022 14:11:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 9 Nov 2022 14:11:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 25741422E9 for ; Wed, 9 Nov 2022 14:11:11 +0100 (CET) Message-ID: <6746d883-dbeb-8a7d-70a0-70a9484d4f5a@proxmox.com> Date: Wed, 9 Nov 2022 14:11:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20221018140226.598710-1-d.csapak@proxmox.com> From: Aaron Lauterer In-Reply-To: <20221018140226.598710-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH cluster/qemu-server/container/wt/manager v8] add tags to ui X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2022 13:11:42 -0000 I did test it for a bit, and it seems to work a lot better than the last iteration :) From a high level user perspective, I would like to see the following: - a list of configured tags that I am allowed to set in the drop down (the user-tag-privileges list) - better error messages that tell me which tag caused which problem. For example something like: "tag foo is not in list of allowed tags" or "tag bar is reserved for admins" - as user, no GUI action buttons on admin tags Another thing that I noticed, which is not exclusive to this patch series, is that a user without permissions can still open the options in the cluster->options panel and will only get an error when trying to save the changes. Not allowing to open the edit windows could probably be a good idea. Will go through the code and add some more smaller details that I found in the respective patches