From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0EFB61FF143 for ; Mon, 19 Jan 2026 16:01:18 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3F46821FB5; Mon, 19 Jan 2026 16:01:19 +0100 (CET) Message-ID: <673bbd53-e8af-4f60-bec9-e43871950261@proxmox.com> Date: Mon, 19 Jan 2026 16:00:47 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Daniel Kral References: <20251215155334.476984-1-d.kral@proxmox.com> <20251215155334.476984-7-d.kral@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20251215155334.476984-7-d.kral@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1768834793878 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.015 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH ha-manager 6/9] config, manager: factor out resource motion info logic X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 15.12.25 um 4:55 PM schrieb Daniel Kral: > The logic in execute_migration(...) and get_resource_motion_info(...) to > gather dependent and blocking HA resources is equivalent and should also > be the same for consistency, so factor them out as a separate helper. > > The PVE::HA::Helpers package is introduced since there does not exist a > package for shared logic between packages, which cannot depend on each > other (e.g. Manager and Config, LRM and CRM, etc.) and PVE::HA::Tools is > not the right place for these. It is a rather specific helper and PVE::HA::Helpers sounds very general. Could we also put it in PVE::HA::Rules::Helpers or somewhere else below PVE::HA::Rules or is there a good reason not to? _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel