From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 157C11FF17C
for <inbox@lore.proxmox.com>; Wed, 14 May 2025 14:14:30 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 78FAE5098;
Wed, 14 May 2025 14:14:50 +0200 (CEST)
Date: Wed, 14 May 2025 14:14:47 +0200 (CEST)
From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
To: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>,
"pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Message-ID: <672104555.15058.1747224887139@webmail.proxmox.com>
In-Reply-To: <7a7870acf85fdab270549692e05bf436a74c6f3c.camel@groupe-cyllene.com>
References: <20250422115141.808427-1-alexandre.derumier@groupe-cyllene.com>
<mailman.30.1745322744.394.pve-devel@lists.proxmox.com>
<1379246505.14356.1747133287907@webmail.proxmox.com>
<7a7870acf85fdab270549692e05bf436a74c6f3c.camel@groupe-cyllene.com>
MIME-Version: 1.0
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.6-Rev75
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.046 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH qemu-server 14/14] qcow2: add external
snapshot support
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
> DERUMIER, Alexandre <alexandre.derumier@groupe-cyllene.com> hat am 14.05.2025 12:45 CEST geschrieben:
>
>
> >>removed snapshot test2 while VM is running:
> >>
> >>delete qemu external snapshot
> >>stream intermediate snapshot test2 to current
> >stream-drive-scsi1: transferred 309.0 MiB of 32.0 GiB (0.94%) in 0s
> >>stream-drive-scsi1: stream-job finished
> >>delete old /dev/extsnap/snap-test2-vm-106-disk-0.qcow2
> >>TASK ERROR: error deleting snapshot test2
>
> ah, sorry, it come from Lvmplugin:volume_snapshot_delete()
>
> $volname = $class->get_snap_volname($volname, $snap);
> my $cleanup_worker = eval { $class->free_image($storeid, $scfg,
> $volname, $isBase, $format) };
> die "error deleting snapshot $snap $@\n" if $@;
>
>
> where I send the snapvolname to free_image,
> but free_image is dying on parse_volname
>
> my $name = ($class->parse_volname($volname))[1];
>
> I'll create an helper like free_snapshot_image , like you have
> suggested it.
>
>
> >>it seems to me you didn't really test the version you sent w.r.t.
> >>basic snapshot actions?
>
> Maybe I only have restested with qcow2 file in my last batch, and not
> tested the whole lvm free_image changes, sorry :/
I'll continue some testing with the dir part (I thought LVM might be
more interesting to run into performance issues/.. ;))
one thing that I already noticed is that snapshot images are listed like
regular images:
$ pvesm list extsnapdir
Volid Format Type Size VMID
extsnapdir:555/snap-first-vm-555-disk-0.qcow2 qcow2 images 1073741824 555
extsnapdir:555/snap-second-vm-555-disk-0.qcow2 qcow2 images 1073741824 555
extsnapdir:555/vm-555-disk-0.qcow2 qcow2 images 1073741824 555
so we definitely still need to find a way to encode/store those which makes
the snapshot images properly separate from the "main" ones..
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel