From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 562301FF16B for <inbox@lore.proxmox.com>; Thu, 6 Mar 2025 16:15:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 64D9CA1E4; Thu, 6 Mar 2025 16:15:52 +0100 (CET) Message-ID: <667b0d81-4f1f-43f3-9348-fe666fdd08cd@proxmox.com> Date: Thu, 6 Mar 2025 16:15:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: pve-devel@lists.proxmox.com References: <20250208054209.598307-1-thomas@atskinner.net> Content-Language: en-US From: Mira Limbeck <m.limbeck@proxmox.com> In-Reply-To: <20250208054209.598307-1-thomas@atskinner.net> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.308 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH SERIES access-control/docs/manager/perl-rs/proxmox-openid v3] Make OIDC userinfo endpoint optional X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On 2/8/25 06:42, Thomas Skinner wrote: > Continues work on adding an option to disable querying the userinfo endpoint for an > OIDC provider. > > Changes since v2: > - Adjust verify_authorization_code in pve-rs to be backwards compatible > - Fix defaults in wrapper functions > > access-control: > > Thomas Skinner (1): > fix #4234: add library functions for openid optional userinfo request > > src/PVE/API2/OpenId.pm | 6 +++++- > src/PVE/Auth/OpenId.pm | 7 +++++++ > 2 files changed, 12 insertions(+), 1 deletion(-) > > > docs: > > Thomas Skinner (1): > fix #4234: add docs for openid optional userinfo request > > pveum.adoc | 8 ++++++++ > 1 file changed, 8 insertions(+) > > > manager: > > Thomas Skinner (1): > fix #4234: add GUI option for openid optional userinfo request > > www/manager6/dc/AuthEditOpenId.js | 9 +++++++++ > 1 file changed, 9 insertions(+) > > > perl-rs: > > Thomas Skinner (1): > fix #4234: openid: adjust openid verification function for userinfo > option > > pve-rs/src/openid/mod.rs | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > > proxmox-openid: > > Thomas Skinner (1): > fix #4234: openid: add library functions for optional userinfo > endpoint > > proxmox-openid/src/lib.rs | 30 +++++++++++++++++++++++++++++- > 1 file changed, 29 insertions(+), 1 deletion(-) > > Thank you for the patch series! I've tested it with Authentik, and checked with tcpdump to see if the userinfo endpoint was queried. Works as I would expect. I had to manually apply the pve-rs patch since code was moved around since then. More information as reply to the patch itself. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel