From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DD5488335A for ; Fri, 3 Dec 2021 09:03:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C8F4F21BFA for ; Fri, 3 Dec 2021 09:03:27 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6039021BEB for ; Fri, 3 Dec 2021 09:03:27 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2C329442AC for ; Fri, 3 Dec 2021 09:03:27 +0100 (CET) To: pve-devel@lists.proxmox.com, Oguz Bektas References: <20211202133842.1000372-1-o.bektas@proxmox.com> From: Fabian Ebner Message-ID: <6670482a-986b-d81d-bde1-96d0c8de48ee@proxmox.com> Date: Fri, 3 Dec 2021 09:03:26 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211202133842.1000372-1-o.bektas@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.809 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.3 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [tools.pm] Subject: Re: [pve-devel] [PATCH common] fix #3747: download_file_from_url: trim whitespace before comparing checksum X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Dec 2021 08:03:57 -0000 Am 02.12.21 um 14:38 schrieb Oguz Bektas: > so that we don't get checksum mismatch in case the user accidentally > copies whitespace in the checksum field. > Isn't this better done in the UI? Or at least upon parameter validation (but we don't do this for any other parameter, or)?. > Signed-off-by: Oguz Bektas > --- > src/PVE/Tools.pm | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm > index 787942a..fa14f2f 100644 > --- a/src/PVE/Tools.pm > +++ b/src/PVE/Tools.pm > @@ -1921,6 +1921,7 @@ sub download_file_from_url { > if (defined($opts->{"${_}sum"})) { > $checksum_algorithm = $_; > $checksum_expected = $opts->{"${_}sum"}; > + $checksum_expected =~ s/^\s+|\s+$//g; > last; > } > } >