From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D6B249DB8F for ; Fri, 24 Nov 2023 16:33:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B418911F37 for ; Fri, 24 Nov 2023 16:33:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 24 Nov 2023 16:33:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0E5C843C68 for ; Fri, 24 Nov 2023 16:33:13 +0100 (CET) Date: Fri, 24 Nov 2023 16:33:12 +0100 (CET) From: Dietmar Maurer To: Proxmox VE development discussion , Maximiliano Sandoval Message-ID: <664251523.1602.1700839992094@webmail.proxmox.com> In-Reply-To: <20231124145815.179803-1-m.sandoval@proxmox.com> References: <20231124145815.179803-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev54 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.373 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH widget-toolkit] node: repos: Use won't rather than don't X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Nov 2023 15:33:44 -0000 Do you also plan to fix those typos in the translation files? Else we need to re-tralstale them for all languages! > On 24.11.2023 15:58 CET Maximiliano Sandoval wrote: > > > It would be preferable to use "won't" but I would rather err on the safe > side when it comes to escapes in gettext. > > Signed-off-by: Maximiliano Sandoval > --- > src/node/APTRepositories.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js > index 4e74da2..f27e713 100644 > --- a/src/node/APTRepositories.js > +++ b/src/node/APTRepositories.js > @@ -471,7 +471,7 @@ Ext.define('Proxmox.node.APTRepositories', { > > if (!enterprise && !nosubscription && !test) { > addCritical( > - Ext.String.format(gettext('No {0} repository is enabled, you do not get any updates!'), vm.get('product')), > + Ext.String.format(gettext('No {0} repository is enabled, you would not get any updates!'), vm.get('product')), > ); > } else if (errors.length > 0) { > // nothing extra, just avoid that we show "get updates" > -- > 2.39.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel