From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8FE926B758 for ; Fri, 11 Dec 2020 16:21:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 87BE322724 for ; Fri, 11 Dec 2020 16:21:20 +0100 (CET) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E794A22714 for ; Fri, 11 Dec 2020 16:21:18 +0100 (CET) Received: by mail-wm1-x341.google.com with SMTP id c198so7868931wmd.0 for ; Fri, 11 Dec 2020 07:21:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=odiso-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=WBWUdjPmZ+6XqTvIXcDyOL9M1niOVS3jWlvN2owvwo8=; b=RXRd6Wk2HCiH32HCliVZPFhJHr9NjIhjTIGGes2lBXI8SMyGc3LyX9nPbxT+a/9TpW JILktjpopLQdVJeSKThxdVUyvMn6KraHXOdDC/4zTGMY1fKRe91XxNsh4SkYKr8MU14f iF+oH+z/P/6j5mrwlZgPnNwXENRiHJMIF8YkrdNk+dGzYHCpaaHOf0UfVIJFFf1vCalp 4rJS/iSsu3AQ4DdnyEZ7UfYL3UcQ36O02SeKGMlknSvObbtoqk3zHoS6CH4yPE3bviu6 SMkZMCBj8Bci7EtdzjL6xe2X64ylOQQh4/YjpKCHY9M/cGiiE0rhfuS37xgFc2OSpwcL p+AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=WBWUdjPmZ+6XqTvIXcDyOL9M1niOVS3jWlvN2owvwo8=; b=pKUkFX7V8Rb6ZuWxPar+WBHfNjbQOMJDOzBaxeZwFbnlANzgamYwKnyK1QrG97r4+S PqPbK/6656Mzixi1B3l35NvFsmnaJVqV4WrrjWQzKInfJ0h6fy6vApkFXMYZDCP42Jo+ L9K5f5FcnAS2LElxuYbZNOIFXsY3i4juEYlNhbseWa/VHMY1dL1Df9HVdlwhwyFIoxtS SPVqCPVhdTVqTKgZuqOz/FhLUwa+FNZt7fOoYz2MU1Hp+CR5djenJGp0wBjoF49sSvjV 4w5H5X2kjZUePxdn4XEVytKMgy3eJUL6G6os0lLGUD19cXO7fjJGZINY5Sdf3Z1967j5 xxtg== X-Gm-Message-State: AOAM531Z1425YBS1hiauCHrZJNA0JaInzIbJzN/3nyXPuPyix2QKcT2M UM44pxXSTjGSwE2+UordgwzvDKqSROVLFYpK X-Google-Smtp-Source: ABdhPJzfRUXh0EWe5PNekoX3AuEbBg7jIuEzNoXk6p+ZT5ysGh+O5t/1p2YY2+NztcZ/lBCh2gJg7g== X-Received: by 2002:a1c:68d6:: with SMTP id d205mr14156991wmc.154.1607700072058; Fri, 11 Dec 2020 07:21:12 -0800 (PST) Received: from [10.59.100.98] (globalOdiso.M6Lille.odiso.net. [89.248.211.242]) by smtp.gmail.com with ESMTPSA id w189sm3555605wmg.31.2020.12.11.07.21.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Dec 2020 07:21:11 -0800 (PST) To: Stefan Reiter , pve-devel@lists.proxmox.com References: <20201210152338.19423-1-s.reiter@proxmox.com> From: alexandre derumier Message-ID: <65a13332-5322-21f0-b08c-61088b843298@odiso.com> Date: Fri, 11 Dec 2020 16:21:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <20201210152338.19423-1-s.reiter@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 0.819 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [RFC pve-qemu] disable jemalloc X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Dec 2020 15:21:20 -0000 AFAIK, It was mainly for rbd performance, but performance is fixed now (with glibc from buster). So, I think we don't need it anymore. On 10/12/2020 16:23, Stefan Reiter wrote: > jemalloc does not play nice with our Rust library (proxmox-backup-qemu), > specifically it never releases memory allocated from Rust to the OS. > This leads to a problem with larger caches (e.g. for the PBS block driver). > > It appears to be related to this GitHub issue: > https://github.com/jemalloc/jemalloc/issues/1398 > > The background_thread solution seems weirdly hacky, so let's disable > jemalloc entirely for now. > > Signed-off-by: Stefan Reiter > --- > > @Alexandre: you were the one to introduce jemalloc into our QEMU builds a long > time ago - does it still provide a measurable benefit? If the performance loss > would be too great in removing it, we could maybe figure out some workarounds as > well. > > Its current behaviour does seem rather broken to me though... > > debian/rules | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/debian/rules b/debian/rules > index c73d6a1..57e1c91 100755 > --- a/debian/rules > +++ b/debian/rules > @@ -60,7 +60,6 @@ config.status: configure > --enable-docs \ > --enable-glusterfs \ > --enable-gnutls \ > - --enable-jemalloc \ > --enable-libiscsi \ > --enable-libusb \ > --enable-linux-aio \