From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4AC3A85BF7 for ; Tue, 21 Dec 2021 09:28:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3954626B5F for ; Tue, 21 Dec 2021 09:27:44 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C5AF626B51 for ; Tue, 21 Dec 2021 09:27:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 9744A451D9 for ; Tue, 21 Dec 2021 09:27:43 +0100 (CET) Message-ID: <655cd024-a651-e85e-d2e1-cbbe71c64603@proxmox.com> Date: Tue, 21 Dec 2021 09:27:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101 Thunderbird/96.0 Content-Language: en-GB To: Dominik Csapak , Proxmox VE development discussion References: <20211220113300.3090910-1-d.csapak@proxmox.com> <2982a5c1-3475-c4e7-e830-da69911fcf30@proxmox.com> From: Thomas Lamprecht In-Reply-To: <2982a5c1-3475-c4e7-e830-da69911fcf30@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.012 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH novnc] add patches to workaround fullscreen issue in android app X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Dec 2021 08:28:14 -0000 On 21/12/2021 08:05, Dominik Csapak wrote: > On 12/20/21 20:53, Thomas Lamprecht wrote: >> On 20/12/2021 12:33, Dominik Csapak wrote: >>> patch 15 hides the fullscreen button, >>> patch 16 make the error message dismissable >>> >> >> this seems broken? >> >> The d/patches/series file gets 16 and 17 added: >> >> 0016-hide-fullscreen-button-on-isFullscreen-get-variable.patch >> 0017-make-error-hideable.patch >> >> So above is at least confusing, but actually this diff then only includes the >> 0017 patch, which then makes it completely wrong?! > > what do you mean? > admittedly i forgot to mention that this only applies on top of the > v1.3.0 upgrade, but the patches are ... ah, I got confused by the truncated name in the short log and you wrongly referring to patch 15 and patch 16 in the commit message..