From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2C25DAB73 for ; Mon, 21 Nov 2022 15:58:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DC61A2E08E for ; Mon, 21 Nov 2022 15:58:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 21 Nov 2022 15:58:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 416D244D89 for ; Mon, 21 Nov 2022 15:58:10 +0100 (CET) Message-ID: <6555ae82-7d41-7c43-df41-121f1897bdf6@proxmox.com> Date: Mon, 21 Nov 2022 15:58:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:108.0) Gecko/20100101 Thunderbird/108.0 Content-Language: en-GB To: Proxmox VE development discussion , Fiona Ebner References: <20221116140435.93067-1-f.ebner@proxmox.com> <20221116140435.93067-2-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221116140435.93067-2-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.030 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager 1/6] api: vzdump: soften parameter permission checks X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2022 14:58:42 -0000 Am 16/11/2022 um 15:04 schrieb Fiona Ebner: > Allows sufficiently privileged users to pass-in retention and > performance parameters for manual backup, but keeps tmpdir, dumpdir > and script root-only. Such users could already edit the job > accordingly, so essentially not granting anything new. > > Suggested-by: Thomas Lamprecht > Signed-off-by: Fiona Ebner > --- > PVE/API2/Backup.pm | 15 ++++++++++----- > PVE/API2/VZDump.pm | 25 ++++++++++++++++++------- > 2 files changed, 28 insertions(+), 12 deletions(-) > > almost forgot: as talked off-list: applied this one for now as its relatively nonintrusive and fixes the annoying "can edit job but cannot press run-no" issue, thanks!