From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 7BF1B1FF0E5 for ; Wed, 15 Jul 2026 12:26:55 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4C6F62143E; Wed, 15 Jul 2026 12:26:55 +0200 (CEST) Message-ID: <64c8114d-981f-4fe6-a7a8-db6add96071b@proxmox.com> Date: Wed, 15 Jul 2026 12:26:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH manager v9 4/5] fix #7339: lvm: add discard-on-remove option to UI To: Lukas Sichert , pve-devel@lists.proxmox.com References: <20260713160008.121125-1-l.sichert@proxmox.com> <20260713160008.121125-5-l.sichert@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260713160008.121125-5-l.sichert@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784111163800 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.250 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3VXI7DJSX47YT6M2OZSG2RYLGHUWREAN X-Message-ID-Hash: 3VXI7DJSX47YT6M2OZSG2RYLGHUWREAN X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 13.07.26 um 6:00 PM schrieb Lukas Sichert: > The LVM storage plugin can now use the `discard` option of the > `on-volume-remove` property string to discard allocated blocks before > removing an LV. > > Expose this option in the LVM storage edit window with a local > `on-remove-discard` checkbox. Serialize the checkbox into the `discard` > property of `on-volume-remove`, and delete the property again when the > option is disabled. > > Also rename the `imgdel` task description from "Erase data" to "Destroy > image", since the task can now also discard storage blocks. > > Signed-off-by: Lukas Sichert > Link: bugzilla.proxmox.com/show_bug.cgi?id=7339 Reviewed-by: Fiona Ebner