From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BD391BBC9A for ; Tue, 19 Dec 2023 13:10:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9A66437512 for ; Tue, 19 Dec 2023 13:10:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 19 Dec 2023 13:10:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BA08748587 for ; Tue, 19 Dec 2023 13:10:42 +0100 (CET) Message-ID: <6452ff13-8fba-4c5a-9600-42af4c3ee746@proxmox.com> Date: Tue, 19 Dec 2023 13:10:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Stefan Hanreich References: <20231215135154.284412-1-s.hanreich@proxmox.com> Content-Language: en-US From: Friedrich Weber In-Reply-To: <20231215135154.284412-1-s.hanreich@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.111 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH pve-manager v2] postinst: filter rbds in lvm X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2023 12:10:43 -0000 Tested-by: Friedrich Weber Tried a couple of upgrades from PVE 7 to PVE 8 (including pve-manager with this patch). When upgrading, dpkg asks (in most cases) whether to keep local /etc/lvm/lvm.conf or install package maintainer version, so I tried both answers. Results were as I'd expect. I'm showing the pre- and post-upgrade contents of the `devices {}` block below. * default PVE 7 lvm.conf (with zvol filter): ** keeping local version => post-upgrade lvm.conf: # added by pve-manager to avoid scanning ZFS zvols and Ceph rbds # global_filter=["r|/dev/zd.*|"] global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"] ** installing package maintainer version => post-upgrade lvm.conf: # added by pve-manager to avoid scanning ZFS zvols and Ceph rbds global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"] * custom lvm.conf 7 with "# added" marker: # added by pve-manager to avoid scanning ZFS zvols global_filter=["r|/dev/zd.*|", "r|/dev/foo|"] ** keeping local version => custom config is kept and untouched ** installing package maintainer version => post-upgrade lvm.conf: # added by pve-manager to avoid scanning ZFS zvols and Ceph rbds global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"] * custom lvm.conf on PVE 7 without "# added" marker: global_filter=["r|/dev/zd.*|", "r|/dev/foo|"] ** keeping local version: => custom config is kept and untouched ** install package maintainer version => post-upgrade lvm.conf: # added by pve-manager to avoid scanning ZFS zvols and Ceph rbds global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"] * upstream unmodified lvm.conf without any global_filter LVM does not ask which version to take => post-upgrade lvm.conf: # added by pve-manager to avoid scanning ZFS zvols and Ceph rbds global_filter=["r|/dev/zd.*|","r|/dev/rbd.*|"]