From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0BD6A76940 for ; Tue, 19 Oct 2021 15:04:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D975A2DB15 for ; Tue, 19 Oct 2021 15:04:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9694B2DB06 for ; Tue, 19 Oct 2021 15:04:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0236F468F1 for ; Tue, 19 Oct 2021 15:04:04 +0200 (CEST) Message-ID: <641ef788-8ede-d6dc-7697-2fa41ee00a5e@proxmox.com> Date: Tue, 19 Oct 2021 15:04:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Content-Language: en-US To: Proxmox VE development discussion , Thomas Lamprecht , Dominik Csapak References: <20210922092749.2386238-1-d.csapak@proxmox.com> <724abcda-3bda-dbe6-ac18-7b81339fe284@proxmox.com> From: Aaron Lauterer In-Reply-To: <724abcda-3bda-dbe6-ac18-7b81339fe284@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.240 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] partially-applied: [PATCH manager v2 00/12] multi tab disk panel & multi disk wizard X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2021 13:04:06 -0000 On 10/4/21 09:36, Thomas Lamprecht wrote: > On 22.09.21 11:27, Dominik Csapak wrote: >> this series is intended to replace dominics and my previous attempts >> at this [0][1][2] >> >> splits the bandwidth options into their on tab on the disk panel and >> introduces a 'MultiHDEdit' panel which creates/deletes the >> HDEdit panels on demand. >> >> The UX is modeled after Dominics first attempt, but a very different >> approach code-wise. instead of having a seperate 'data' panel that >> contains the vm config, let the multi disk panel handle that >> and pass it through to the panels below. this way the HDEdit does >> not need a big code-change to get/set the config. >> >> changes from v1: >> * fixed a bug which prevented the wizard from finishing >> * made the wizard a little wider so that the form field labes are >> readable >> * added logic to use the ostype to determine the first disk if one >> deleted all before >> >> patch 10/12 and 12/12 are new, other changes are in 11/12 >> >> 0: https://lists.proxmox.com/pipermail/pve-devel/2021-June/048690.html >> 1: https://lists.proxmox.com/pipermail/pve-devel/2021-July/049295.html >> 2: https://lists.proxmox.com/pipermail/pve-devel/2021-September/050013.html >> >> Dominik Csapak (12): >> ui: qemu/HDEdit: move Bandwidth options to a different tab >> ui: form/ControllerSelector: set correct max value for the device-id >> ui: refactor sortByPreviousUsage and nextFreeDisk >> ui: form/ControllerSelector: add updateVMConfig and getConfId >> ui: qemu/HDEdit: use me instead of this >> ui: qemu/HDEdit: fire an event when the disk id changes >> ui: qemu/OSTypeEdit: drop throwing an error on multiple widgets >> ui: Utils: add capture group for the id in bus_match >> ui: form/ControllerSelector: add option for selecting free on inital >> config >> ui: qemu/OSTypeEdit: set ostype in viewmodel > > applied above, delayed below; mostly because I'd like to have some feedback from > others here and I'd also like to have the same for CT, to avoid a feature drift in > the wizards. I took the last two patches for a quick spin, and I have to say that I do like the functionality. Yes it does change the way one interacts with the wizard quite a bit, but it really makes it so much easier to create VMs with no disks at all (useful when preparing for qm importdisk) or more than one disk. > > thanks! > >> ui: add qemu/MultiHDEdit and use it in the wizard >> ui: window/Wizard: make it a little wider >> >> www/manager6/Makefile | 1 + >> www/manager6/Utils.js | 48 +++- >> www/manager6/form/ControllerSelector.js | 65 +++--- >> www/manager6/qemu/CreateWizard.js | 4 +- >> www/manager6/qemu/HDEdit.js | 143 ++++++++---- >> www/manager6/qemu/MultiHDEdit.js | 294 ++++++++++++++++++++++++ >> www/manager6/qemu/OSTypeEdit.js | 3 +- >> www/manager6/window/Wizard.js | 7 +- >> 8 files changed, 482 insertions(+), 83 deletions(-) >> create mode 100644 www/manager6/qemu/MultiHDEdit.js >> > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >