From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B2733978EA for ; Wed, 17 Apr 2024 12:04:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 927142309 for ; Wed, 17 Apr 2024 12:04:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 17 Apr 2024 12:04:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DCD7141E20 for ; Wed, 17 Apr 2024 12:04:10 +0200 (CEST) Message-ID: <6412a657-7c79-4c87-ae74-5b6ae725a542@proxmox.com> Date: Wed, 17 Apr 2024 12:03:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Thomas Lamprecht , Proxmox VE development discussion References: <20240417084419.37338-1-f.schauer@proxmox.com> <7d97b66f-4b3d-4276-908b-1d3ad3d91034@proxmox.com> From: Filip Schauer In-Reply-To: <7d97b66f-4b3d-4276-908b-1d3ad3d91034@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.071 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] applied: [PATCH v5 manager 0/2] add edit window for device passthrough X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Apr 2024 10:04:16 -0000 That is already fixed by this commit to pve-container: https://git.proxmox.com/?p=pve-container.git;a=commitdiff;h=556ddd393165d51653fe32c1f8fe8628d1802219 On 17/04/2024 11:54, Thomas Lamprecht wrote: > Also noticed something not related to the UI side: if I enter some bogus path, > like `/dev/enoent`, I correctly get an error that this does not exist, but the > config entry is added nonetheless! > Which then also means that if I keep the dialogue open and correct the dev > path, I won't be able to submit as the config digest changed, I need to close > and re-open the add/edit dialogue again. This is not only bad UX, but seems > completely broken? > > Also, if I got some bogus devX entries already, the error I get when saving > a new one is often from them, not from the one I add, but the change also > goes through here... > > Please check that out.