From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id CDD9F6270B
 for <pve-devel@pve.proxmox.com>; Mon, 13 Jul 2020 12:38:36 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id BFBD119BBC
 for <pve-devel@pve.proxmox.com>; Mon, 13 Jul 2020 12:38:06 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 2B3BD19BAD
 for <pve-devel@pve.proxmox.com>; Mon, 13 Jul 2020 12:38:05 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E5F6742134
 for <pve-devel@pve.proxmox.com>; Mon, 13 Jul 2020 12:38:04 +0200 (CEST)
To: PVE development discussion <pve-devel@pve.proxmox.com>,
 Fabian Ebner <f.ebner@proxmox.com>
References: <20200707082003.17274-1-f.ebner@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Message-ID: <640a9632-1ecd-e6ea-ac02-1b2c897d25db@proxmox.com>
Date: Mon, 13 Jul 2020 12:38:03 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.0
MIME-Version: 1.0
In-Reply-To: <20200707082003.17274-1-f.ebner@proxmox.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.000 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: [pve-devel] applied: [PATCH qemu-server] set resume parameter for
 vm_start_nolock if there is a vmstate
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 13 Jul 2020 10:38:36 -0000

On 07.07.20 10:20, Fabian Ebner wrote:
> In config_to_command, '-loadstate' will be added whenever there is a
> vmstate in the config. But in vm_start_nolock, the resume parameter
> is used to calculate the appropriate timeout and to remove the vmstate
> after the start. The resume parameter was only set if there is a
> 'suspended' lock, but apparently [0] we cannot rely on the lock to be
> set if and only if there is a vmstate.
> 
> [0]: https://forum.proxmox.com/threads/task-error-start-failed.72450
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  PVE/QemuServer.pm | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
>

Was initially a bit unsure about this, but as the addition of "loadstate" happens
since quite a bit this makes it at least work (again), so applied, thanks!