From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C41078AAA3 for ; Fri, 19 Aug 2022 12:01:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B997319048 for ; Fri, 19 Aug 2022 12:01:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 19 Aug 2022 12:01:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C6402433F8; Fri, 19 Aug 2022 12:01:08 +0200 (CEST) Message-ID: <63fbf096-d456-6538-d6b2-c6c6ff5c69fe@proxmox.com> Date: Fri, 19 Aug 2022 12:01:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: Matt Corallo , pve-devel@lists.proxmox.com References: From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [lxc.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH] Update cpu.weight default to match documented default X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2022 10:01:09 -0000 Hi, On 16.08.22 05:49, Matt Corallo wrote: > Proxmox documentation describes the default CPU weight as 1024 in > numerous places. However, when unset, the Linux default CGROUP > weight is 100. > I'm not saying increasing the timeout can't be worth it, but I haven't seen many reports about the default being too low. There is a patch in the works [0] allowing to set custom options in the storage configuration for CIFS which would allow changing the timeout only for setups that actually require it. [0]: https://lists.proxmox.com/pipermail/pve-devel/2022-July/053645.html P.S. re-sending while including the pve-devel list > This simply always writes an `lxc.cgroup2.cpu.weight` option to the > LXC config file, defaulting to 1024 instead of omitting the option > entirely. > > Signed-off-by: Matt Corallo > --- >  src/PVE/LXC.pm | 3 +++ >  1 file changed, 3 insertions(+) > > diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm > index fe63087..ca453a9 100644 > --- a/src/PVE/LXC.pm > +++ b/src/PVE/LXC.pm > @@ -712,6 +712,9 @@ sub update_lxc_config { >          die "cpu weight (shares) must be in range [1, 10000]\n" >          if $shares < 1 || $shares > 10000; >          $raw .= "lxc.cgroup2.cpu.weight = $shares\n"; > +    } else { > +        # Default as documented > +        $raw .= "lxc.cgroup2.cpu.weight = 1024\n"; >      } >      } >