From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 977091FF163 for ; Thu, 7 Nov 2024 14:52:01 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 39772308D6; Thu, 7 Nov 2024 14:52:12 +0100 (CET) Message-ID: <63dde2f2-2234-434b-9a42-ffd2a50fb33a@proxmox.com> Date: Thu, 7 Nov 2024 14:52:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20241107112521.2075598-1-d.csapak@proxmox.com> From: Aaron Lauterer In-Reply-To: <20241107112521.2075598-1-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.036 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH docs/widget-toolkit/manager v3] implement tagview X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" gave this a quick test. two things I noticed: * root element in tree per tag: wouldn't it be better to override the display style to 'full'? Otherwise I might have a lot of colorful dots, but don't know what the tags are called. * I am not 100% sure, but would it be possible to distinguish guests that have no tag assigned a bit better? maybe have a default "no-tags" tree for them? On 2024-11-07 12:25, Dominik Csapak wrote: > this adds a 'tagview' to the web ui, organizing guests by their tags > (for details see the pve-manager patch) > > I'm not super happy all in all with how much special casing must be > done, but i could not (yet?) figure out a better way. > > changes from v2: > * rebased on master (tooltip generation changed so adapted to that) > * implemented fionas feedback, so selection should stay even when tags > are removed or the selection is changed from the tag view > > changes from v1: > * rebase on master > * adapt to recent tooltip changes > * add a comment to TagConfig class to better explain what it does > > pve-docs: > > Dominik Csapak (1): > gui: add anchor for tags chapter > > pve-gui.adoc | 1 + > 1 file changed, 1 insertion(+) > > proxmox-widget-toolkit: > > Dominik Csapak (1): > css: add some conditions to the tag classes for the tag view > > src/css/ext6-pmx.css | 22 +++++++++++++++------- > 1 file changed, 15 insertions(+), 7 deletions(-) > > pve-manager: > > Dominik Csapak (1): > ui: implement 'Tag View' for the resource tree > > www/manager6/Makefile | 1 + > www/manager6/Workspace.js | 4 +- > www/manager6/form/ViewSelector.js | 28 +++++++++++ > www/manager6/grid/ResourceGrid.js | 2 +- > www/manager6/panel/TagConfig.js | 6 +++ > www/manager6/tree/ResourceTree.js | 81 ++++++++++++++++++++++++++++--- > 6 files changed, 113 insertions(+), 9 deletions(-) > create mode 100644 www/manager6/panel/TagConfig.js > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel