From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <a.zeidler@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 2DC81950BC
for <pve-devel@lists.proxmox.com>; Thu, 11 Apr 2024 19:12:37 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 070D6356DC
for <pve-devel@lists.proxmox.com>; Thu, 11 Apr 2024 19:12:07 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Thu, 11 Apr 2024 19:12:06 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C086944C59
for <pve-devel@lists.proxmox.com>; Thu, 11 Apr 2024 19:12:05 +0200 (CEST)
Message-ID: <638a68f6be333d38b4161e16f83e318086475d50.camel@proxmox.com>
From: Alexander Zeidler <a.zeidler@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, Proxmox VE development
discussion <pve-devel@lists.proxmox.com>
Date: Thu, 11 Apr 2024 19:12:05 +0200
In-Reply-To: <fa3fded3-6404-42f7-a6cf-02dfcc023856@proxmox.com>
References: <20240322135933.164404-1-a.zeidler@proxmox.com>
<20240322135933.164404-5-a.zeidler@proxmox.com>
<fa3fded3-6404-42f7-a6cf-02dfcc023856@proxmox.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4-2
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.050 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
POISEN_SPAM_PILL 0.1 Meta: its spam
POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes
POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH manager 5/9] report: move `lscpu` & cluster
info to more appropriate sections
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 11 Apr 2024 17:12:37 -0000
On Mon, 2024-03-25 at 09:11 +0100, Thomas Lamprecht wrote:
> And why are those more appropriate? Both fit's the general "always import=
ant"
> section, so even though they fit the section you moved them too, they als=
o
> fit the general one, so some actual reasoning here would be good..
>=20
> On 22/03/2024 14:59, Alexander Zeidler wrote:
> > Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> > ---
> > PVE/Report.pm | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >=20
> > diff --git a/PVE/Report.pm b/PVE/Report.pm
> > index 2c2a5e12..505629c7 100644
> > --- a/PVE/Report.pm
> > +++ b/PVE/Report.pm
> > @@ -41,8 +41,6 @@ my $init_report_cmds =3D sub {
> > 'cat /etc/apt/sources.list',
> > sub { dir2text('/etc/apt/sources.list.d/', '.+\.list') },
> > sub { dir2text('/etc/apt/sources.list.d/', '.+\.sources') },
> > - 'lscpu',
Because of the commands from [PATCH manager 9/9]:
+ 'apt list *microcode 2>/dev/null | column -tL',
+ 'dmesg | grep -i "microcode\|vuln"',
which are associated to the lscpu output. But due to your suggestions in
[PATCH manager 9/9], like:
> I'm wondering if instead of having a handful of dmesg + grep instances
> it makes more sense to just add the whole dmesg output as separate
> file.
both patches can be dropped.
> > - 'pvesh get /cluster/resources --type node --output-format=3Dyaml',
This move just felt more appropriate since we have a dedicated cluster sect=
ion.
Beside that we often jump to or filter for keywords, so the actual position=
might
not be that important. I'm fine with dropping this change and stick with th=
e
position we are used to.
> > ],
> > },
> > 'system-load' =3D> {
> > @@ -96,6 +94,7 @@ my $init_report_cmds =3D sub {
> > order =3D> 60,
> > cmds =3D> [
> > 'pvecm nodes',
> > + 'pvesh get /cluster/resources --type node --output-format=3Dyaml',
> > 'pvecm status',
> > 'cat /etc/pve/corosync.conf 2>/dev/null',
> > 'ha-manager status',
> > @@ -106,6 +105,7 @@ my $init_report_cmds =3D sub {
> > order =3D> 70,
> > cmds =3D> [
> > 'dmidecode -t bios',
> > + 'lscpu',
> > 'lspci -nnk',
> > ],
> > },
>=20