From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 69F48932FD
 for <pve-devel@lists.proxmox.com>; Mon, 19 Feb 2024 15:58:34 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 40F8E32108
 for <pve-devel@lists.proxmox.com>; Mon, 19 Feb 2024 15:58:04 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Mon, 19 Feb 2024 15:58:03 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6B41D43810
 for <pve-devel@lists.proxmox.com>; Mon, 19 Feb 2024 15:58:03 +0100 (CET)
Message-ID: <6301e566-939f-4cd6-9ea8-d632d88cad86@proxmox.com>
Date: Mon, 19 Feb 2024 15:58:02 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Filip Schauer <f.schauer@proxmox.com>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20231219094023.25726-1-f.schauer@proxmox.com>
 <20231219094023.25726-4-f.schauer@proxmox.com>
 <9e131d9f-af31-46b8-be0f-4d343d1c0d6c@proxmox.com>
In-Reply-To: <9e131d9f-af31-46b8-be0f-4d343d1c0d6c@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.071 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pve-devel] [PATCH v7 qemu-server 2/4] Prevent starting a
 32-bit VM using a 64-bit OVMF BIOS
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 19 Feb 2024 14:58:34 -0000

Am 19.02.24 um 15:47 schrieb Fiona Ebner:
>> +
>> +	if (my $model = $builtin_models->{$cputype}) {
>> +	    $cputype = $model->{'reported-model'};
>> +	} elsif (is_custom_model($cputype)) {
>> +	    my $custom_cpu = get_custom_model($cputype);
>> +	    $cputype = $custom_cpu->{'reported-model'} // $cpu_fmt->{'reported-model'}->{default};
>> +	}
> 
> Missing the logic for the replacement type, i.e.
> 	if (my $replacement_type = $depreacated_cpu_map->{$cputype}) {
> 	    $cputype = $replacement_type;
> 	}
> 

Well, I suppose it doesn't matter, because we can expect the replacement
type to have the same bitness.