From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2DF469947 for ; Fri, 1 Apr 2022 17:21:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2328928CFF for ; Fri, 1 Apr 2022 17:20:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A124A28CF4 for ; Fri, 1 Apr 2022 17:20:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 66B7B41CBE for ; Fri, 1 Apr 2022 17:20:34 +0200 (CEST) Message-ID: <62eaab20-ab74-bb7d-e413-0c897832ee8d@proxmox.com> Date: Fri, 1 Apr 2022 17:20:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:99.0) Gecko/20100101 Thunderbird/99.0 Content-Language: en-US To: Proxmox VE development discussion , Daniel Tschlatscher References: <20220401140758.1997754-1-d.tschlatscher@proxmox.com> <20220401140758.1997754-2-d.tschlatscher@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220401140758.1997754-2-d.tschlatscher@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager] Replaced system-report file download X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2022 15:21:05 -0000 On 01.04.22 16:07, Daniel Tschlatscher wrote: > with a function call to the newly added textToFile() function in > the utils class (Proxmox.Utils). please refer to the fact that it got moved to proxmox-widget-toolkit to imply the required dependency bump more explicitly. > > Signed-off-by: Daniel Tschlatscher > --- > www/manager6/node/Subscription.js | 14 +------------- > 1 file changed, 1 insertion(+), 13 deletions(-) > > diff --git a/www/manager6/node/Subscription.js b/www/manager6/node/Subscription.js > index 2558f523..d3502eca 100644 > --- a/www/manager6/node/Subscription.js > +++ b/www/manager6/node/Subscription.js > @@ -61,19 +61,7 @@ Ext.define('PVE.node.Subscription', { > var fileContent = Ext.String.htmlDecode(reportWindow.getComponent('system-report-view').html); > var fileName = getReportFileName(); > > - // Internet Explorer > - if (window.navigator.msSaveOrOpenBlob) { > - navigator.msSaveOrOpenBlob(new Blob([fileContent]), fileName); > - } else { > - var element = document.createElement('a'); > - element.setAttribute('href', 'data:text/plain;charset=utf-8,' + > - encodeURIComponent(fileContent)); > - element.setAttribute('download', fileName); > - element.style.display = 'none'; > - document.body.appendChild(element); > - element.click(); > - document.body.removeChild(element); > - } > + Proxmox.Utils.textToFile(fileName, fileContent); > }, > }, > ], fyi, there's another similar usage in the PVE.Storage.PBSKeyShow class, maybe there are more - please also check PMG/PBS if not already done.