From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <f.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id E89DE70CA4
for <pve-devel@lists.proxmox.com>; Tue, 6 Apr 2021 08:26:58 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id D9DE629A38
for <pve-devel@lists.proxmox.com>; Tue, 6 Apr 2021 08:26:58 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[212.186.127.180])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS id 8511729A28
for <pve-devel@lists.proxmox.com>; Tue, 6 Apr 2021 08:26:57 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 493B841F4F
for <pve-devel@lists.proxmox.com>; Tue, 6 Apr 2021 08:26:57 +0200 (CEST)
To: pve-devel@lists.proxmox.com
References: <20210402123636.27037-1-f.ebner@proxmox.com>
From: Fabian Ebner <f.ebner@proxmox.com>
Message-ID: <62c7149e-d029-295f-2a38-102fae14889a@proxmox.com>
Date: Tue, 6 Apr 2021 08:26:50 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210402123636.27037-1-f.ebner@proxmox.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.007 Adjusted score from AWL reputation of From: address
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
NICE_REPLY_A -0.001 Looks like a legit reply (A)
RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/,
medium trust
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH container] fix #3367: skip bind mounts when
converting to template
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 06 Apr 2021 06:26:59 -0000
It turns out that we do not yet allow cloning from container templates
with bind mounts. So in a sense container templates with bind mounts are
currently misconfigured, and this patch would make it easier to get there...
Should I send a v2 with a patch making cloning from such templates
possible, or were there some concerns to not allow it in the first
place? There is a
# TODO: allow bind mounts?
comment in the clone API call.
Am 02.04.21 um 14:36 schrieb Fabian Ebner:
> Restoring a backup of a template with a bind mount point failed, because the
> volume_has_feature check would fail.
>
> Fix this by skipping bind mounts on template creation. There is no check against
> adding a bind mount with 'pct set' *after* converting to a template, so it
> shouldn't be an issue if we also allow conversion if bind mounts are present *at*
> conversion time.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> src/PVE/LXC.pm | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
> index 6395d12..5a9f76d 100644
> --- a/src/PVE/LXC.pm
> +++ b/src/PVE/LXC.pm
> @@ -1186,6 +1186,8 @@ sub template_create {
> PVE::LXC::Config->foreach_volume($conf, sub {
> my ($ms, $mountpoint) = @_;
>
> + return if $mountpoint->{type} eq 'bind';
> +
> my $volid = $mountpoint->{volume};
>
> die "Template feature is not available for '$volid'\n"
> @@ -1195,6 +1197,8 @@ sub template_create {
> PVE::LXC::Config->foreach_volume($conf, sub {
> my ($ms, $mountpoint) = @_;
>
> + return if $mountpoint->{type} eq 'bind';
> +
> my $volid = $mountpoint->{volume};
>
> PVE::Storage::activate_volumes($storecfg, [$volid]);
>