From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id B8A151FF0AA
	for <inbox@lore.proxmox.com>; Tue, 20 Oct 2026 14:29:18 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 71019216BE;
	Tue, 20 Oct 2026 14:29:01 +0200 (CEST)
Message-ID: <624701f3-08fc-40b5-9279-50cefa1afbe6@proxmox.com>
Date: Tue, 20 Oct 2026 14:28:54 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH qemu-server 4/5] tests: make qm mock accept disk command
To: Thomas Ellmenreich <t.ellmenreich@proxmox.com>,
 pve-devel@lists.proxmox.com
References: <20261019095346.175659-1-t.ellmenreich@proxmox.com>
 <20261019095346.175659-5-t.ellmenreich@proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <20261019095346.175659-5-t.ellmenreich@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1792499334791
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.353 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: Y7N7P6XFR3K7ILQSKBVXOH4TLBHIMQVF
X-Message-ID-Hash: Y7N7P6XFR3K7ILQSKBVXOH4TLBHIMQVF
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 19.10.26 um 11:54 AM schrieb Thomas Ellmenreich:
> The integration tests fail if the mock does not recognize 'qm disk' as a
> valid command, so add it as an option.
> 

This is not true at this stage. It only becomes relevant with the next
patch, so it should just be part of that directly.

> Signed-off-by: Thomas Ellmenreich <t.ellmenreich@proxmox.com>
> ---
>  src/test/MigrationTest/QemuMigrateMock.pm | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/test/MigrationTest/QemuMigrateMock.pm b/src/test/MigrationTest/QemuMigrateMock.pm
> index c715a60e..4741b1d1 100644
> --- a/src/test/MigrationTest/QemuMigrateMock.pm
> +++ b/src/test/MigrationTest/QemuMigrateMock.pm
> @@ -374,6 +374,8 @@ $MigrationTest::Shared::tools_module->mock(
>                          return 0;
>                      } elsif ($cmd eq 'stop') {
>                          return 0;
> +                    } elsif ($cmd eq 'disk') {
> +                        return 0;
>                      }
>                      die "run_command (mocked) ssh qm command - implement me: ${cmd_msg}";
>                  } elsif ($cmd eq 'pvesm') {