From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 5CC641FF178 for ; Mon, 1 Dec 2025 11:53:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6304619539; Mon, 1 Dec 2025 11:53:56 +0100 (CET) Message-ID: <623c44ed-bbad-4c3a-b5c1-66f5a47f8d5c@proxmox.com> Date: Mon, 1 Dec 2025 11:53:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Stoiko Ivanov References: <20251126180819.817240-1-s.ivanov@proxmox.com> <20251126180819.817240-3-s.ivanov@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20251126180819.817240-3-s.ivanov@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1764586390537 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.017 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH installer 2/2] common: pinning: use pve-iface regular expression for validation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 26.11.25 um 7:08 PM schrieb Stoiko Ivanov: > + static RE: OnceLock = OnceLock::new(); > + let re = RE.get_or_init(|| { > + RegexBuilder::new(r"^[a-z][a-z0-9_]{1,20}([:\.]\d+)?$") Should the later part with a colon really be allowed? On the new test ISO, a name like 'nicat:3' will be accepted, but won't actually work later when booting: "Interface name is not valid or too long, ignoring assignment: nicat:3" I guess the dot can make sense if there are multiple NICs, so you could have e.g. 'nic0' and 'nic0.3'? > + .case_insensitive(true) > + .build() > + .unwrap() > + }); > + _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel