From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B374B6361F for ; Fri, 25 Feb 2022 09:27:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9FF1A1FF3F for ; Fri, 25 Feb 2022 09:26:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 16DD31FF33 for ; Fri, 25 Feb 2022 09:26:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DB19046E20 for ; Fri, 25 Feb 2022 09:26:41 +0100 (CET) Message-ID: <6236827c-0bcc-abee-791d-1dda43dfefed@proxmox.com> Date: Fri, 25 Feb 2022 09:26:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US To: Dietmar Maurer , Proxmox VE development discussion References: <433512123.3099.1645720104625@webmail.proxmox.com> From: Stefan Sterz In-Reply-To: <433512123.3099.1645720104625@webmail.proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH qemu-server v2 4/4] parse vm config: remove "\s*" from multi-line comment regex X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Feb 2022 08:27:12 -0000 On 24.02.22 17:28, Dietmar Maurer wrote: > >> On 02/24/2022 3:49 PM Stefan Sterz wrote: >> >> >> To be consistent with PBS's implementation of multi-line comments >> remove "\s*" here too. Since the regex isn't lazy .* matches >> everything \s* would anyway. > > But the old regex trimm spaces from the end, so this is quite different! It would if the ".*" was evaluated lazily (as in ".*?"), but from my testing it isn't. So since ".*" matches spaces greedily, they are actually not trimmed. The only character that is matched by "\s" and not by "." are line breaks, but those occur after the "$". Hence, "\s" should never match anything here. I've also discussed this with Wolfgang Bumiller off list.