From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EEB2A70F02 for ; Tue, 7 Jun 2022 14:54:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DF0D62DF1F for ; Tue, 7 Jun 2022 14:54:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BA10F2DF12 for ; Tue, 7 Jun 2022 14:54:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8D17043A56 for ; Tue, 7 Jun 2022 14:54:10 +0200 (CEST) Message-ID: <618f0831-0c07-7cfc-8465-a723c1bda70c@proxmox.com> Date: Tue, 7 Jun 2022 14:54:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: pve-devel@lists.proxmox.com, s.hrdlicka@proxmox.com References: <20220524144532.2698959-1-s.hrdlicka@proxmox.com> <20220524144532.2698959-2-s.hrdlicka@proxmox.com> From: Fabian Ebner In-Reply-To: <20220524144532.2698959-2-s.hrdlicka@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.508 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.889 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [config.pm] Subject: Re: [pve-devel] [PATCH pve-storage 1/2] fix #2822: add lvm, lvmthin & zfs storage on all cluster nodes X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Jun 2022 12:54:42 -0000 Am 24.05.22 um 16:45 schrieb Stefan Hrdlicka: > this enables forwarding of request to the correct node if a node is set > > Signed-off-by: Stefan Hrdlicka > --- > PVE/API2/Storage/Config.pm | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/PVE/API2/Storage/Config.pm b/PVE/API2/Storage/Config.pm > index 6bd770e..82b73ca 100755 > --- a/PVE/API2/Storage/Config.pm > +++ b/PVE/API2/Storage/Config.pm > @@ -146,6 +146,13 @@ __PACKAGE__->register_method ({ > protected => 1, > path => '', > method => 'POST', > + proxyto_callback => sub { > + my ($rpcenv, $proxyto, $uri_param) = @_; > + my $node = delete $uri_param->{node}; Messing with the uri params here is hacky. It destroys the consistency between the API schema and what the API call actually handles. It's not really required to proxy the call to a specific node. The only downside is that we don't do an early storage access check if the storage is not enabled for the current node. > + $node = "localhost" if !$node; > + > + return $node; > + }, > description => "Create a new storage.", > permissions => { > check => ['perm', '/storage', ['Datastore.Allocate']],