From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 34CA0905D2 for ; Thu, 22 Sep 2022 10:19:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 10AC66444 for ; Thu, 22 Sep 2022 10:18:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 22 Sep 2022 10:18:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 416CB4448E for ; Thu, 22 Sep 2022 10:18:48 +0200 (CEST) Message-ID: <6133ed51-6660-9d52-6df8-38caa287c4d9@proxmox.com> Date: Thu, 22 Sep 2022 10:18:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Content-Language: en-US To: Thomas Lamprecht , Proxmox VE development discussion References: <20220919091621.29538-1-f.ebner@proxmox.com> <765748c9-d21f-68c7-e6c4-8406cf0bbccd@proxmox.com> From: Fiona Ebner In-Reply-To: <765748c9-d21f-68c7-e6c4-8406cf0bbccd@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.888 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -3.702 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager 1/2] ui: qemu: CD edit: add "Installation media" label when in wizard X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Sep 2022 08:19:19 -0000 Am 19.09.22 um 13:00 schrieb Thomas Lamprecht: > Bit torn on this one, otoh it's small and might help some, otoh I think that > it shouldn't be required - there's OS in the tab title already and a disk tab > two steps ahead, that paired with the fact that there's clearly written "CD/DVD > drive" so it should be pretty easy to understand, and if not that extra hint > isn't probably adding that much of extra info over the existing cues, also note, > and here I'm probably over analysing/nit-picking, but it doesn't necesarrily > needs to be a installation media, e.g. for a live distro. > Yes, if somebody actually reads the text, it should be clear what the storage is for ;) > The heading fits somewhat with the one from the OS type selector, so from a purely > layout POV it would be fine to have. Maybe just some other wording, like a plain/ > technical "Virtual CD/DVD Drive". > What about "Installation/Live media"? Should be accurate enough for the vast majority of scenarios and I think, it'd provide a good hint to new users. It also would avoid repeating "CD/DVD", but I'm fine with your suggestion too :)