From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4389D91CF4 for <pve-devel@lists.proxmox.com>; Sat, 11 Mar 2023 18:01:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2068A2B716 for <pve-devel@lists.proxmox.com>; Sat, 11 Mar 2023 18:01:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Sat, 11 Mar 2023 18:01:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5033D41DA3 for <pve-devel@lists.proxmox.com>; Sat, 11 Mar 2023 18:01:18 +0100 (CET) Message-ID: <60ff5428-fa59-c253-0ac2-38cfaa4dbdde@proxmox.com> Date: Sat, 11 Mar 2023 18:01:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:111.0) Gecko/20100101 Thunderbird/111.0 Content-Language: en-GB, de-AT To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Friedrich Weber <f.weber@proxmox.com> References: <20230309123019.1080105-1-f.weber@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20230309123019.1080105-1-f.weber@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.050 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH cluster] pvecm add: require user to navigate out of /etc/pve X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Sat, 11 Mar 2023 17:01:49 -0000 Am 09/03/2023 um 13:30 schrieb Friedrich Weber: > If `pvecm add` is issued from /etc/pve (or any subdirectory), it > prints some errors: > > [...] > shell-init: error retrieving current directory: getcwd: cannot > access parent directories: Transport endpoint is not connected > [...] > successfully added node 'pve-c2' to cluster. > cannot fetch initial working directory: Transport endpoint is not > connected at /usr/share/perl5/PVE/CLI/pvecm.pm line 446. > > The reason is that `pvecm add` restarts pmxcfs, which re-mounts the > fuse mount at /etc/pve, invalidating pvecm's working directory. > > The error messages give the impression that something went wrong. > Indeed, the second error indicates the temporary directory is not > cleaned up. The cluster join itself actually works, though. > > The issue could be fixed by chdir'ing to / in `pvecm add`. However, > the user's shell would still remain in the now-invalid /etc/pve, > potentially leading to confusing "transport endpoint not connected" > messages in future interactions. > > To avoid this, require the user to chdir out of /etc/pve before > running `pvecm add`. > > Signed-off-by: Friedrich Weber <f.weber@proxmox.com> > --- > data/PVE/CLI/pvecm.pm | 6 ++++++ > 1 file changed, 6 insertions(+) > > applied, thanks!