From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id B65BA1FF2D3 for ; Fri, 12 Jul 2024 11:43:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4928E3FECE; Fri, 12 Jul 2024 11:43:31 +0200 (CEST) Message-ID: <60a2ef0f-4b8a-4986-ba36-b4255a2b4190@proxmox.com> Date: Fri, 12 Jul 2024 11:42:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion , Christoph Heiss References: <20240711115804.706227-1-c.heiss@proxmox.com> From: Aaron Lauterer In-Reply-To: <20240711115804.706227-1-c.heiss@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.039 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [config.pm, proxmox.com, install.pm, zfs.pm, setup.rs, utils.rs, zfs-get-pool-list.pl] Subject: Re: [pve-devel] [PATCH installer v3 0/4] add check/rename for already-existing ZFS rpool X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" tested this series more thoroughly and checked with an existing root pool all 3 install options: * TUI * GUI * auto Worked well in 3 cases to rename. One oddity seems to be if we cancel the rename in the TUI installer. it jumps to 100% and stays there and I then need to manually abort. Jumping to a "setup cancelled" box that we confirm before quitting would be nice. This is how the GUI installer handles it. Otherwise, besides this and a tiny nit in patch 4, consider this: Reviewed-By: Aaron Lauterer Tested-By: Aaron Lauterer On 2024-07-11 13:57, Christoph Heiss wrote: > Pretty straight forward overall, implements a check for an existing > `rpool` on the system and ask the user whether they would like to rename > it, much in the same way as it works for VGs already. > > Without this, the installer would silently create a second (and thus > conflicting) `rpool` and cause a boot failure after the installation, > since it does not know which pool to import exactly. > > v1: https://lists.proxmox.com/pipermail/pve-devel/2024-May/063874.html > v2: https://lists.proxmox.com/pipermail/pve-devel/2024-July/064619.html > > Notable changes v2 -> v3: > * make low-level option lvm_auto_rename more generic > * skip rename prompt in auto-install mode > > Notable changes v1 -> v2: > * incorporated Aarons suggestions from v1 > * rewrote tests to use a pre-defined input instead > * moved pool renaming to own subroutine > * documented all new subroutines > * split out tests into own patch > > Christoph Heiss (4): > test: add test cases for new zfs module > low-level: install: check for already-existing `rpool` on install > install: config: rename option lvm_auto_rename -> > existing_storage_auto_rename > low-level: install: automatically rename existing rpools on > auto-installs > > Proxmox/Install.pm | 35 +++++++++++- > Proxmox/Install/Config.pm | 6 +- > Proxmox/Sys/ZFS.pm | 20 ++++++- > proxmox-auto-installer/src/utils.rs | 2 +- > .../resources/parse_answer/disk_match.json | 2 +- > .../parse_answer/disk_match_all.json | 2 +- > .../parse_answer/disk_match_any.json | 2 +- > .../tests/resources/parse_answer/minimal.json | 2 +- > .../resources/parse_answer/nic_matching.json | 2 +- > .../resources/parse_answer/specific_nic.json | 2 +- > .../tests/resources/parse_answer/zfs.json | 2 +- > proxmox-installer-common/src/setup.rs | 2 +- > proxmox-tui-installer/src/setup.rs | 2 +- > test/Makefile | 7 ++- > test/zfs-get-pool-list.pl | 57 +++++++++++++++++++ > 15 files changed, 128 insertions(+), 17 deletions(-) > create mode 100755 test/zfs-get-pool-list.pl > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel