From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EC65973857 for ; Fri, 18 Jun 2021 13:38:35 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E727E271B1 for ; Fri, 18 Jun 2021 13:38:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7FF37271A3 for ; Fri, 18 Jun 2021 13:38:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 55A2743E6B for ; Fri, 18 Jun 2021 13:38:35 +0200 (CEST) Message-ID: <603b714c-6b11-cf03-b6e2-b28cdaa7b1fd@proxmox.com> Date: Fri, 18 Jun 2021 13:38:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20210618113409.32548-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210618113409.32548-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.815 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager] ui: fix Guest Summary Notes height X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 11:38:36 -0000 On 18.06.21 13:34, Dominik Csapak wrote: > fixes 'infinite' height of the guest notes, by setting the height on the > container a level up > > the notes view itself is already scrollable, so if it is too large, > there'll be a scrollbar > > this does not change anything for templates, as there we show nothing > under the notes and thus there the infinite height is ok > did not saw any complaints there, but it's a really easy fix so I'm going to cherry-pick it > Signed-off-by: Dominik Csapak > --- > should apply to stable-6 too if we want that > www/manager6/panel/GuestStatusView.js | 2 -- > www/manager6/panel/GuestSummary.js | 1 + > 2 files changed, 1 insertion(+), 2 deletions(-) > > wow, that was fast. applied, thanks!