From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6A4E994DF0 for ; Mon, 16 Jan 2023 14:26:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 450AB271C7 for ; Mon, 16 Jan 2023 14:26:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 16 Jan 2023 14:26:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 950FF44CB8 for ; Mon, 16 Jan 2023 14:26:18 +0100 (CET) Message-ID: <6004a5af-8619-26a7-bc0a-2b8e12483691@proxmox.com> Date: Mon, 16 Jan 2023 14:26:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 Content-Language: en-GB To: Proxmox VE development discussion , Stefan Hanreich References: <20221216124506.316371-1-s.hanreich@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221216124506.316371-1-s.hanreich@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH pve-manager] fix #4393: ui: storage backup view: make pbs-specific columns sortable X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jan 2023 13:26:53 -0000 Am 16/12/2022 um 13:45 schrieb Stefan Hanreich: > The sort order is analogous to how it behaves in the datastore content > overview in pbs. > > This means sorting in ascending order behaves as follows: > > Verify State > * failed > * none > * ok > > Encryption > * no > * yes > > For the encryption state there is theoretically a distinction between > signed and encrypted, but as far as I can tell we do not render this > distinction in PVE, which is why I chose to not make this distinction > for sorting as well. > > Signed-off-by: Stefan Hanreich > --- > www/manager6/Utils.js | 7 +++++++ > www/manager6/storage/BackupView.js | 12 ++++++++++++ > 2 files changed, 19 insertions(+) > > diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js > index 8c118fa2..3dd287e3 100644 > --- a/www/manager6/Utils.js > +++ b/www/manager6/Utils.js > @@ -1963,6 +1963,13 @@ Ext.define('PVE.Utils', { > }, > > tagCharRegex: /^[a-z0-9+_.-]+$/i, > + > + verificationStateOrder: { > + 'failed': 0, > + 'none': 1, > + 'ok': 2, > + '__default__': 3, > + }, Not that your patch is really at fault here, but made me notice again that we really need to make Utils go away, it's a real dump for so much stuff that it's just becoming gross.. It should be split up and stuff moved either directly where its actually used, to specialized classes, even if on the smaller side, or to more generic but sensible "aggregative" classes like one for Schema stuff (but not utils, helper, tools anymore). > }, > > singleton: true, > applied, thanks!