From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AAB2D8374 for ; Wed, 21 Jun 2023 12:33:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8B0931B5F1 for ; Wed, 21 Jun 2023 12:32:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 21 Jun 2023 12:32:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4AE1E42162 for ; Wed, 21 Jun 2023 12:32:55 +0200 (CEST) Date: Wed, 21 Jun 2023 12:32:54 +0200 From: Christoph Heiss To: Proxmox VE development discussion Message-ID: <5zdqw5yi2rx3rwz4frk47w4obetyl7hsrmgxp3bctnocdyhawy@dxhqowihjrdj> References: <20230621091609.38721-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230621091609.38721-1-m.sandoval@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.079 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [bootdisk.rs, proxmox.com] Subject: Re: [pve-devel] [PATCH installer] tui: Add a cancel button to Advanced bootdisk options X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2023 10:33:26 -0000 LGTM. On Wed, Jun 21, 2023 at 11:16:09AM +0200, Maximiliano Sandoval wrote: > This matches the GUI installer which counts with a close (x) button. > Reviewed-by: Christoph Heiss > Signed-off-by: Maximiliano Sandoval > --- > proxmox-tui-installer/src/views/bootdisk.rs | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/proxmox-tui-installer/src/views/bootdisk.rs b/proxmox-tui-installer/src/views/bootdisk.rs > index 3fdbe5b..eaf343d 100644 > --- a/proxmox-tui-installer/src/views/bootdisk.rs > +++ b/proxmox-tui-installer/src/views/bootdisk.rs > @@ -456,6 +456,7 @@ fn advanced_options_view(disks: &[Disk], options: Rc>) > &(*options).borrow(), > )) > .title("Advanced bootdisk options") > + .dismiss_button("Cancel") > .button("Ok", { > let options_ref = options.clone(); > move |siv| { > -- > 2.39.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >