From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8ED451FF163 for <inbox@lore.proxmox.com>; Thu, 5 Dec 2024 14:17:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 544441A5E6; Thu, 5 Dec 2024 14:17:08 +0100 (CET) Date: Thu, 5 Dec 2024 14:17:04 +0100 From: Gabriel Goller <g.goller@proxmox.com> To: Lukas Wagner <l.wagner@proxmox.com> Message-ID: <5vt6likn666v6qmp7vltpjneavrmw2xayxmb63mcycdshubpne@akntfjnletrk> References: <20241205102348.216706-1-g.goller@proxmox.com> <20241205102348.216706-2-g.goller@proxmox.com> <a02a2bdb-2632-4448-9c68-4dca4a6b6e2e@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <a02a2bdb-2632-4448-9c68-4dca4a6b6e2e@proxmox.com> User-Agent: NeoMutt/20241002-35-39f9a6 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.035 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2] log: add perlmod logger X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Cc: pve-devel@lists.proxmox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> >Minor nit: repo in the subject prefix is missing, also the order of patches should probably reversed. Happens when you don't use murpp, am I right? :) >Seems to work fine, now messages logged by proxmox-notify while being in task context show up >in the task logs again. Only downside to this approach is that we now also log to stderr >in regular daemon (non-task) context? I don't think this is an issue tho? I think we nearly always call perlmod functions in tasks anyway so it should be fine. Worst case is you get duplicated errors in the journal (i.e. stderr routed to journal and normal journal print). >Small (visual) improvement would be to log the severity as well, similar to the rest of the task logs. > >E.g. > >INFO: notified via ... >ERROR: could not notify via ... > >At the moment the prefix is not there, which is inconsistent to the other messages in the task log. The usual tracing output is without the colon, so "ERROR ...msg...", but I'll see what I can do (Worst case would be another custom layer). >Consider this: > >Tested-by: Lukas Wagner <l.wagner@proxmox.com> Thanks for the review! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel