From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 3CC701FF13F for ; Thu, 07 May 2026 09:15:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 27A8DBD2B; Thu, 7 May 2026 09:15:28 +0200 (CEST) Date: Thu, 7 May 2026 09:14:49 +0200 From: Arthur Bied-Charreton To: David Riley Subject: Re: [PATCH docs/manager/qemu-server v4 00/17] Add API and UI for custom CPU models Message-ID: <5lzuttlpzjkwvne5oicicuvgdesmdnxiegw7vprz4kuhdafuts@4zstsvybw6e6> References: <20260430160109.565536-1-a.bied-charreton@proxmox.com> <519f4203-a378-479f-a3ba-41d62bed672b@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <519f4203-a378-479f-a3ba-41d62bed672b@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1778137982468 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.789 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Message-ID-Hash: S3CN2FROA7SCZ2GNKHTAKDMCR35Y3UXS X-Message-ID-Hash: S3CN2FROA7SCZ2GNKHTAKDMCR35Y3UXS X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hey David, thanks a lot for testing! On Wed, May 06, 2026 at 04:31:05PM +0200, David Riley wrote: > Thanks for the patch. This seems to be a nice addition. > > I’ve tested the series and found a regression in the VM creation > wizard. When creating a Windows guest with the 'Add additional drive > for VirtIO drivers' checkbox enabled and an ISO Image is added, > the creation fails with: > > 'Parameter verification failed. (400) ide0: > explicit media=cdrom is required for iso images' > > Looking at the request payload, the 'media=cdrom' property is missing > for the VirtIO ISO: > >   Before: ide0: "sani:iso/virtio-win-0.1.271.iso,media=cdrom" >   Now: ide0: "sani:iso/virtio-win-0.1.271.iso" > I was able to reproduce this on a fresh PVE VM with pve-manager 9.1.10. The culprit is commit f196d28f on pve-manager, which moved the ISO selector to a new panel, but omitted the onGetValues hook that was adding media=cdrom. I confirmed the issue with Dominik and sent a patch fixing it [0]. > I also noticed that the wizard now defaults to the IDE bus for disks > instead of SCSI, when the Guest OS Type Microsoft Windows is selected. > This came with commit 6be73bfe on pve-manager, which made some changes to the sorting priority of that field. I think this is intentional? Maybe @Dominik can confirm. > > On 4/30/26 5:59 PM, Arthur Bied-Charreton wrote: [...] [0] https://lore.proxmox.com/pve-devel/20260507065517.237996-1-a.bied-charreton@proxmox.com/T/#u