From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 02BA41FF2C5 for ; Mon, 8 Jul 2024 17:17:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 039349A86; Mon, 8 Jul 2024 17:17:21 +0200 (CEST) Date: Mon, 8 Jul 2024 17:16:48 +0200 From: Christoph Heiss To: Aaron Lauterer Message-ID: <5jealoq4akmv3hmzmd45ud7z4ajc3yljdumulgbl62ndy6ibbe@a2lmxc2ukzqj> References: <20240516102837.422278-1-c.heiss@proxmox.com> <20240516102837.422278-4-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.009 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH installer 3/3] low-level: install: check for already-existing `rpool` on install X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On Mon, Jul 08, 2024 at 04:16:23PM GMT, Aaron Lauterer wrote: > On 2024-05-16 12:28, Christoph Heiss wrote: > > [..] > > +sub zfs_ask_existing_zpool_rename { > > + my ($pool_name) = @_; > > + > > + # At this point, no pools should be imported/active > > + my $exported_pools = Proxmox::Sys::ZFS::get_exported_pools(); > > + > > + foreach (@$exported_pools) { > > + next if $_->{name} ne $pool_name || $_->{state} ne 'ONLINE'; > > + my $renamed_pool = "$_->{name}-OLD-" . random_short_uid(); > > since the pool already has a unigue numerical id, couln't we use that > instead of generating a new one? Good point, I will change that. Only thing I might have to look into is the maximum pool name length, since the numerical IDs are quite long. But in the worst case, they should still be unique enough even after shortening to an appropriate length. > > we even have everything in place with $_->{id}. > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel