From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0AA4D9A781 for ; Fri, 17 Nov 2023 13:34:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DBCAA32CA7 for ; Fri, 17 Nov 2023 13:33:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 17 Nov 2023 13:33:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A1D0543DC6 for ; Fri, 17 Nov 2023 13:33:28 +0100 (CET) Date: Fri, 17 Nov 2023 13:33:27 +0100 From: Christoph Heiss To: Thomas Lamprecht Cc: Proxmox VE development discussion Message-ID: <5gfiebbvah3c4ysivgtqbih3txhdx3bvzx6pkvbwxn33aos46r@ttvteuzpn3cu> References: <20231117121319.482709-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [bootdisk.rs] Subject: Re: [pve-devel] applied: [PATCH installer] tui: fix changing between non-LVM and LVM filesystem in bootdisk chooser X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2023 12:34:00 -0000 Thanks! On Fri, Nov 17, 2023 at 01:20:31PM +0100, Thomas Lamprecht wrote: > > Am 17/11/2023 um 13:12 schrieb Christoph Heiss: > > Happens due to a force-unwrap() under the false assumption that the > > disk for LVM configurations always exists when switching to a LVM > > filesystem. > > This fails spectacularly with a panic when switching from e.g. Btrfs to > > ext4 in the filesystem chooser. > > > > Fixes: eda9fa0 ("fix #4856: tui: bootdisk: use correct defaults in advanced dialog") > > Reported-by: Christian Ebner > > Signed-off-by: Christoph Heiss > > --- > > proxmox-tui-installer/src/views/bootdisk.rs | 29 +++++++++++---------- > > 1 file changed, 15 insertions(+), 14 deletions(-) > > > > > > applied, thanks! > > Could be nice to get the installer code unwrap free in the future, or > at least add a safety comment for each case (but preferably the former) Definitely! It's on my todo-list, and most occurences are already gone since introducing the TUI, fortunately.