From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <s.hanreich@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0E229941C7 for <pve-devel@lists.proxmox.com>; Wed, 21 Feb 2024 15:21:09 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E477B1922C for <pve-devel@lists.proxmox.com>; Wed, 21 Feb 2024 15:21:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Wed, 21 Feb 2024 15:21:08 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 14323444F8; Wed, 21 Feb 2024 15:21:08 +0100 (CET) Message-ID: <5f44d791-b924-4a21-a6a8-9573dee8bf8d@proxmox.com> Date: Wed, 21 Feb 2024 15:21:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Jillian Morgan <jillian.morgan@primordial.ca> References: <20240126171741.2251760-1-jillian.morgan@primordial.ca> From: Stefan Hanreich <s.hanreich@proxmox.com> In-Reply-To: <20240126171741.2251760-1-jillian.morgan@primordial.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.499 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [inotify.pm, proxmox.com] Subject: Re: [pve-devel] [PATCH close #545, #5203: Allow bridges to have any valid interface name 0/2] X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 21 Feb 2024 14:21:09 -0000 Hi! Thanks for your patch! In general we like the idea of being able to choose arbitrary names for bridges - but there's some additional things to consider before we can apply those patches. We are currently using prefixes for other types of interfaces as well. With this patch series I could create bridges named 'bondX' which are then picked up as a bond by the Web UI since the check for that in INotify.pm is located before the check for bridges. It would be a bit weird to name a bridge with the prefix bond admittedly, but we should try to handle this more gracefully (iow. check first whether an entry is a bridge and only then check for the other cases) It might make sense to check for any possible conflicts with the SDN config (running & staged). I've added some additional comments inline - I can look into a v2 addressing those issues. On 1/26/24 18:17, Jillian Morgan wrote: > Allow bridges to have any valid interface name > > The patches are 1-line each, but across two repositories: > proxmox-widget-toolkit (Toolkit.js) > pve-common (INotify.pm) > > Jillian Morgan (2): > Allow bridges to have any valid interface name > Detect bridge interface by bridge_ports attribute > > src/Toolkit.js | 2 +- > src/PVE/INotify.pm | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >