From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D58F761CC7 for ; Thu, 10 Feb 2022 14:55:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D34521DD18 for ; Thu, 10 Feb 2022 14:55:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D93A31DD0F for ; Thu, 10 Feb 2022 14:55:56 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B050A46DCB for ; Thu, 10 Feb 2022 14:55:56 +0100 (CET) Message-ID: <5f3677d9-501f-bd86-4e25-6b79a94cdd75@proxmox.com> Date: Thu, 10 Feb 2022 14:55:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20220210112836.616619-1-o.bektas@proxmox.com> From: Aaron Lauterer In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v2 manager] ui: vm network: allow to override MTU for virtio devices X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Feb 2022 13:55:57 -0000 On 2/10/22 14:53, Aaron Lauterer wrote: > Looks good AFAICT and does what we want. > > We could improve it further by adding a small validator. Otherwise the user will only notice their error once they get the error msg from the API. > > A quick way that I came up with that could potentially be done better: > > diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js > index 1e34ad1c..2566d1a8 100644 > --- a/www/manager6/qemu/NetworkEdit.js > +++ b/www/manager6/qemu/NetworkEdit.js > @@ -184,6 +184,13 @@ Ext.define('PVE.qemu.NetworkInputPanel', { >                 bind: { >                     disabled: '{!isVirtio}', >                 }, > +               validator: function(value) { > +                   if (value === "" || (value > 0 && value <= 65520)) { > +                       return true; > +                   } else { > +                       return gettext("must be between 0 and 65520"); The message here should of course read 1 instead of 0... > +                   } > +               }, >                 allowBlank: true, >             }, >         ];