From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id 7B81D1FF0AA
	for <inbox@lore.proxmox.com>; Tue, 22 Sep 2026 16:33:43 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 46397215BB;
	Tue, 22 Sep 2026 16:33:35 +0200 (CEST)
Message-ID: <5eb6b7f4-2810-4d76-a7af-aeb7cf821154@proxmox.com>
Date: Tue, 22 Sep 2026 16:33:30 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH qemu-server v5 4/7] api: record VM ID as used on creation,
 cloning, and destruction
To: =?UTF-8?Q?Michael_K=C3=B6ppl?= <m.koeppl@proxmox.com>,
 pve-devel@lists.proxmox.com
References: <20260921155410.938337-1-m.koeppl@proxmox.com>
 <20260921155410.938337-5-m.koeppl@proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <20260921155410.938337-5-m.koeppl@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1790087610443
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.529 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: 4F7FBB6H2RZFVKAZ5UKDERZXNLPQIVBG
X-Message-ID-Hash: 4F7FBB6H2RZFVKAZ5UKDERZXNLPQIVBG
X-MailFrom: f.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Am 21.09.26 um 5:54 PM schrieb Michael Köppl:
> @@ -6708,6 +6721,11 @@ __PACKAGE__->register_method({
>  
>          PVE::Cluster::check_cfs_quorum();
>  
> +        # remote migration brings in a VMID this cluster has not seen,
> +        # so record it here

Style nit: comment would fit on one line
(same in the next patch)

> +        eval { PVE::UsedGuestIDs::add_id($vmid) };
> +        die "unable to create VM $vmid - could not record VMID as used - $@" if $@;
> +
>          my $lock = 'create';
>          eval { PVE::QemuConfig->create_and_lock_config($vmid, 0, $lock); };
>