From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5601173706 for ; Thu, 7 Oct 2021 14:56:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4F9931A6A4 for ; Thu, 7 Oct 2021 14:56:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D81EA1A696 for ; Thu, 7 Oct 2021 14:56:30 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AAC73458DA for ; Thu, 7 Oct 2021 14:56:30 +0200 (CEST) Message-ID: <5eb47579-e1b9-49b4-ab2d-26fe88445e3f@proxmox.com> Date: Thu, 7 Oct 2021 14:55:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:93.0) Gecko/20100101 Thunderbird/93.0 Content-Language: en-US To: Proxmox VE development discussion , Lorenz Stechauner References: <20211007124253.3484118-1-l.stechauner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211007124253.3484118-1-l.stechauner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 1.193 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.964 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] ui: storage/PBSEdit: add port field X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Oct 2021 12:56:31 -0000 there are a few ways to implement that and the commit message gives zero reasoning about the chosen one, I do not really like that... why not allowing one to enter it as suffix in the host field like we do in PBS for the remotes. An extra field is always distracting for newer users as it's yet another choice one can possible make, On 07.10.21 14:42, Lorenz Stechauner wrote: > Signed-off-by: Lorenz Stechauner > --- > www/manager6/storage/PBSEdit.js | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/www/manager6/storage/PBSEdit.js b/www/manager6/storage/PBSEdit.js > index fcbc9548..0d7b8033 100644 > --- a/www/manager6/storage/PBSEdit.js > +++ b/www/manager6/storage/PBSEdit.js > @@ -465,6 +465,13 @@ Ext.define('PVE.storage.PBSInputPanel', { > fieldLabel: gettext('Server'), > allowBlank: false, > }, > + { > + xtype: me.isCreate ? 'numberfield' : 'displayfield', > + name: 'port', > + value: 8007, > + fieldLabel: gettext('Port'), > + allowBlank: false, > + }, > { > xtype: me.isCreate ? 'textfield' : 'displayfield', > name: 'username', >