From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9CCC6D809 for ; Mon, 21 Aug 2023 13:27:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7D3F216657 for ; Mon, 21 Aug 2023 13:27:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 21 Aug 2023 13:27:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5921F42CEF for ; Mon, 21 Aug 2023 13:27:37 +0200 (CEST) Message-ID: <5e91a159-d79a-840f-ddae-3314e1088610@proxmox.com> Date: Mon, 21 Aug 2023 13:27:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Content-Language: en-US To: Aaron Lauterer , Proxmox VE development discussion References: <20230418122646.3079833-1-a.lauterer@proxmox.com> <5d60e2f0-7d45-75a5-8fd9-506f950c5d2f@proxmox.com> From: Fiona Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 2.074 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -4.279 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] fix #4631: ceph: osd: create: add osds-per-device X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Aug 2023 11:27:38 -0000 Am 21.08.23 um 12:51 schrieb Aaron Lauterer: > responses inline > Feel free to cut away irrelevant bits when responding (could've cut away the commit message myself last time already) ;) > On 8/21/23 10:20, Fiona Ebner wrote: >> I noticed a warning while testing >> >> --> DEPRECATION NOTICE >> --> You are using the legacy automatic disk sorting behavior >> --> The Pacific release will change the default to --no-auto >> --> passed data devices: 1 physical, 0 LVM >> --> relative data size: 0.3333333333333333 >> >> Note that I'm on Quincy, so maybe they didn't still didn't change it :P > > Also shows up when using `ceph-volume lvm batch …` directly. So I guess > not much we can do about it after consulting the man page. We could explicitly pass --no-auto I guess [0]? While it doesn't make a difference, since we only pass one disk to 'batch', it would at least avoid the warning. [0]: https://docs.ceph.com/en/reef/ceph-volume/lvm/batch/ >> >>> +        minimum => '1', >>> +        description => 'OSD services per physical device. Can >>> improve fast NVME utilization.', >> >> Can we add an explicit recommendation against doing it for other disk >> types? I imagine it's not beneficial for those, or? > > What about something like: > "Only useful for fast NVME devices to utilize their performance better."? > Sounds good to me. >> >>> +        }, >>>       }, >>>       }, >>>       returns => { type => 'string' }, >>> @@ -294,6 +300,15 @@ __PACKAGE__->register_method ({ >>>       # extract parameter info and fail if a device is set more than >>> once >>>       my $devs = {}; >>>   +    # allow 'osds-per-device' only without dedicated db and/or wal >>> devs. We cannot specify them with >>> +    # 'ceph-volume lvm batch' and they don't make a lot of sense on >>> fast NVMEs anyway. >>> +    if ($param->{'osds-per-device'}) { >>> +        for my $type ( qw(db_dev wal_dev) ) { >>> +        die "Cannot use 'osds-per-device' parameter with '${type}'" >> >> Missing newline after error message. >> Could also use raise_param_exc(). > > Ah thanks. Will switch it to an `raise_param_exc()` where we don't need > the newline AFAICT? Yes, the function will add a newline.