From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 4B40571DC9
 for <pve-devel@lists.proxmox.com>; Fri, 20 May 2022 15:17:17 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 3BFD21B8A1
 for <pve-devel@lists.proxmox.com>; Fri, 20 May 2022 15:16:47 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id A299F1B894
 for <pve-devel@lists.proxmox.com>; Fri, 20 May 2022 15:16:45 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 69EA443747
 for <pve-devel@lists.proxmox.com>; Fri, 20 May 2022 15:16:45 +0200 (CEST)
Message-ID: <5e49b756-94fa-153b-b005-303f22e72fac@proxmox.com>
Date: Fri, 20 May 2022 15:16:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:101.0) Gecko/20100101
 Thunderbird/101.0
Content-Language: en-GB
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Wolfgang Bumiller <w.bumiller@proxmox.com>
References: <20220517124003.317063-1-w.bumiller@proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
In-Reply-To: <20220517124003.317063-1-w.bumiller@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.017 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [tools.pm, proxmox.com]
Subject: [pve-devel] applied: [PATCH common] tools: use int() on all integer
 syscall parameters
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 20 May 2022 13:17:17 -0000

On 17/05/2022 14:40, Wolfgang Bumiller wrote:
> this should fix an issue where users with custom id mappings
> get bad ownership on intermediate directories caused by the
> rootuid/gid being the string "100000" in perl instead of the
> number 100000...
> 
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
> NOTE: I decided to go through them all, not just `fchownat` which was
> currently problematic (most likely the issue of [1]).
> 
> I hope I got them all right.
> 
> This was a frustrating one.
> 
> pve needs more rust...

+1

> 
> [1] https://forum.proxmox.com/threads/restoring-lxc-from-pbs-fails.108905/#post-471509
> 
>  src/PVE/Tools.pm | 91 ++++++++++++++++++++++++++++++++++--------------
>  1 file changed, 65 insertions(+), 26 deletions(-)
> 
>

applied, thanks!