From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C42936708E for ; Mon, 11 Jan 2021 14:08:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B8FD11ABA2 for ; Mon, 11 Jan 2021 14:08:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id ACFF91AB92 for ; Mon, 11 Jan 2021 14:08:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 721ED44899 for ; Mon, 11 Jan 2021 14:08:36 +0100 (CET) To: Fabian Ebner , pve-devel@lists.proxmox.com References: <20210111123409.24995-1-f.ebner@proxmox.com> From: Stefan Reiter Message-ID: <5d4b5ce4-2ebe-32e8-e236-622acc800c46@proxmox.com> Date: Mon, 11 Jan 2021 14:08:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20210111123409.24995-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.039 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server] tests: mock storage locking for migration tests X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jan 2021 13:08:37 -0000 On 1/11/21 1:34 PM, Fabian Ebner wrote: > by doing it in a local directory instead of /var/lock/pve-manager, which is > used by the installed/non-test PVE code. This also covers the shared case, > which will become relevant after fixing #3229 (currently migration doesn't > touch disks on shared storages). > > Reported-by: Stefan Reiter > Signed-off-by: Fabian Ebner Fixes the issue, though it still fails if you have previously made a build as root, since 'MigrationTest/run' will have the wrong permissions. Maybe include that dir in 'make clean'?