From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 05A281FF16E for <inbox@lore.proxmox.com>; Mon, 31 Mar 2025 10:06:27 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C6A943D97A; Mon, 31 Mar 2025 10:06:15 +0200 (CEST) Message-ID: <5d2f7aa2-22c7-4d61-bda9-2256e82c275a@proxmox.com> Date: Mon, 31 Mar 2025 10:06:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Max Carrara <m.carrara@proxmox.com> References: <20250328171209.503132-1-m.carrara@proxmox.com> Content-Language: en-US From: Fiona Ebner <f.ebner@proxmox.com> In-Reply-To: <20250328171209.503132-1-m.carrara@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.041 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [RFC v1 pve-storage 1/2] (rfc) example: sshfs plugin: add custom storage plugin for sshfs X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Am 28.03.25 um 18:12 schrieb Max Carrara: > - What would be the preferred way to allow specifying whether a > (custom) plugin is shared or not via our API? > > E.g. some external plugins do the following, which (I suppose) > wasn't originally part of the API, but is now, due it being used in > the wild: > > push @PVE::Storage::Plugin::SHARED_STORAGE, 'some-custom-plugin'; > > Would be open for any suggestions on how to support this properly! > Perhaps as a flag in `plugindata()`? Yes, could be done as a storage feature [0]. > - Should we allow custom plugins to define sensitive properties for > their own purposes? If so, how? > > Currently, sensitive props are hardcoded [2] which is sub-optimal, > but gets the job done. However, should third-party plugin authors > need additional / different properties, there's currently no way to > support this. This would perhaps also be useful for this plugin > here, as one could e.g. provide a path to a password file to use for > something like sshpass [3] or similar, but I'm not really sure about > this yet. > > The reason why I'm bringing this up is because the upcoming guide in > the wiki could benefit from a demonstration on how to implement / > handle both cases. Network storages are quite common, can be shared > among nodes in most cases, and may also require one to handle > authentication. See here [0][1] ;) [0]: https://lore.proxmox.com/pve-devel/20250321134852.103871-8-f.ebner@proxmox.com/ [1]: https://lore.proxmox.com/pve-devel/20250321134852.103871-11-f.ebner@proxmox.com/ _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel