From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 168CB96552 for ; Tue, 24 Jan 2023 16:25:28 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EDBFB5E9B for ; Tue, 24 Jan 2023 16:24:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 24 Jan 2023 16:24:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C870045ECB for ; Tue, 24 Jan 2023 16:24:56 +0100 (CET) Message-ID: <5d124158-1ce3-81b9-e1cd-60f4bc20b894@proxmox.com> Date: Tue, 24 Jan 2023 16:24:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 Content-Language: en-GB To: Proxmox VE development discussion , Lukas Wagner References: <20230123131735.400368-1-l.wagner@proxmox.com> <20230123131735.400368-2-l.wagner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230123131735.400368-2-l.wagner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 3.032 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.148 Looks like a legit reply (A) RCVD_IN_DNSWL_HI -5 Sender listed at https://www.dnswl.org/, high trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v2 widget-toolkit 1/1] repo view: replace non-clickable checkbox with icons X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jan 2023 15:25:28 -0000 Am 23/01/2023 um 14:17 schrieb Lukas Wagner: > From a usability view, having a checkbox that is not clickable is pretty > misleading, especially if the visual style is exactly the same as in > other places in the UI where the checkbox is functional. > > Signed-off-by: Lukas Wagner > --- > src/Utils.js | 6 ++++++ > src/node/APTRepositories.js | 8 ++++---- > 2 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/src/Utils.js b/src/Utils.js > index ef0c2b8..5397fd9 100644 > --- a/src/Utils.js > +++ b/src/Utils.js > @@ -100,6 +100,11 @@ utilities: { > return value; > }, > > + render_enabled_icon: function(value) { > + let icon = value ? 'fa-check' : 'fa-minus'; > + return ``; > + }, I know casing is all over the place, but ExtJS uses camelCase and we interact with it a lot, so I'd favor adding new stuff as camelCase over, e.g., snake_case. For this here an arrow function might be worth it, e.g.: renderEnabledIcon: enabled => ``, btw. maybe it's really time to start a "Format" or "Render" class and move all those renderer out from Utils; but the burden of doing so really shouldn't be the one from this series. > + > language_array: function() { > let data = [['__default__', Proxmox.Utils.render_language('')]]; > Ext.Object.each(Proxmox.Utils.language_map, function(key, value) { > @@ -145,6 +150,7 @@ utilities: { > return value ? Proxmox.Utils.enabledText : Proxmox.Utils.disabledText; > }, > > + spurious new line added. > format_expire: function(date) { > if (!date) { > return Proxmox.Utils.neverText; > diff --git a/src/node/APTRepositories.js b/src/node/APTRepositories.js > index ce8f718..c6b45a2 100644 > --- a/src/node/APTRepositories.js > +++ b/src/node/APTRepositories.js > @@ -239,11 +239,11 @@ Ext.define('Proxmox.node.APTRepositoriesGrid', { > > columns: [ > { > - xtype: 'checkcolumn', > header: gettext('Enabled'), > - dataIndex: 'Enabled', > - listeners: { > - beforecheckchange: () => false, // veto, we don't want to allow inline change - to subtle > + dataindex: 'Enabled', > + align: 'center', > + renderer: function(enabled, cell, record) { > + return Proxmox.Utils.render_enabled_icon(record.data.Enabled); > }, could be a one liner without losing clarity: renderer: ({data}) => Proxmox.Utils.renderEnabledIcon(data.Enabled), > width: 90, > },