From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DCC14BA787 for ; Wed, 20 Mar 2024 10:42:41 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B7CCFD0FD for ; Wed, 20 Mar 2024 10:42:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 20 Mar 2024 10:42:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 92AD0469FD for ; Wed, 20 Mar 2024 10:42:09 +0100 (CET) Message-ID: <5cf1224f-5baa-4177-ae04-fe33cead8562@proxmox.com> Date: Wed, 20 Mar 2024 10:42:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: de-AT, en-US To: Proxmox VE development discussion , Max Carrara References: <20240319153250.629369-1-m.carrara@proxmox.com> From: Lukas Wagner In-Reply-To: <20240319153250.629369-1-m.carrara@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.002 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v1 pve-esxi-import-tools 0/5] Improve listvms.py X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Mar 2024 09:42:41 -0000 On 2024-03-19 16:32, Max Carrara wrote: > This series adds a bunch of improvements for listvms.py, most notably > better typing (and thus better linting support) as well as parsing > arguments via the Python STL's `argparse` [0]. For more information, > please see the individual patches. > > All patches were additionally tested in order to ensure that the JSON > output on successful invocations remains unchanged. This was done as > follows: > > # on master > ./listvms.py $ARGS | jq > ref.json > # after each patch > ./listvms.py $ARGS | jq > output.json > diff -u ref.json output.json > > Furthermore, I built the repo's package and installed it on my local > system, and re-added my virtual ESXi host in the storage settings. The > plugin worked as expected - all my VMs on the ESXi hosts showed up and > were able to be live-imported. > Looks good to me. Since this is type-hinted Python code, maybe the following `mypy.ini` would make sense? ``` [mypy] [mypy-pyVmomi] ignore_missing_imports = True [mypy-pyVim.*] ignore_missing_imports = True ``` Otherwise `mypy` complains about missing type stubs for those two modules :) Tested-by: Lukas Wagner Reviewed-by: Lukas Wagner -- - Lukas