From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id C9C041FF170
for <inbox@lore.proxmox.com>; Tue, 19 Nov 2024 12:59:02 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 92D44295C4;
Tue, 19 Nov 2024 12:59:07 +0100 (CET)
Message-ID: <5ccc4a87-d9dc-45b6-93fd-532d326266c1@proxmox.com>
Date: Tue, 19 Nov 2024 12:59:02 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: pve-devel@lists.proxmox.com
References: <20241119104509.77381-1-m.limbeck@proxmox.com>
<s8ov7wj309k.fsf@proxmox.com>
Content-Language: en-US
From: Mira Limbeck <m.limbeck@proxmox.com>
In-Reply-To: <s8ov7wj309k.fsf@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.338 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH installer] warn if maxvz is set and <= 4 GiB
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On 11/19/24 12:55, Maximiliano Sandoval wrote:
>
> Mira Limbeck <m.limbeck@proxmox.com> writes:
>
>> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
>> ---
>> Proxmox/Install.pm | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
>> index c64e1d4..da8fb55 100644
>> --- a/Proxmox/Install.pm
>> +++ b/Proxmox/Install.pm
>> @@ -555,6 +555,10 @@ sub create_lvm_volumes {
>> my $maxvz = Proxmox::Install::Config::get_maxvz();
>> if ($iso_env->{product} eq 'pve' && !defined($maxvz)) {
>> Proxmox::UI::message("Skipping auto-creation of LVM thinpool for guest data due to low space.");
>> + } elsif ($iso_env->{product} eq 'pve') {
>> + Proxmox::UI::message(
>> + "Skipping auto-creation of LVM thinpool for guest data, Maximum data volume size set too low."
>
> Is "Maximum" intentionally uppercased?
>
See v2:
https://lore.proxmox.com/pve-devel/20241119111241.97092-1-m.limbeck@proxmox.com/T/#u
Forgot to change `,` to `.` when changing the text.
>> + );
>> }
>> $datadev = undef;
>> }
>
>
>
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel