From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B734875061 for ; Thu, 2 Jun 2022 14:47:31 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6B6614BA6 for ; Thu, 2 Jun 2022 14:47:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8CD674B94 for ; Thu, 2 Jun 2022 14:47:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 584DA42A48 for ; Thu, 2 Jun 2022 14:47:29 +0200 (CEST) Message-ID: <5bfa2e91-5512-1923-f6f0-c372a66ddaa2@proxmox.com> Date: Thu, 2 Jun 2022 14:47:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20220602112234.1868726-1-s.hrdlicka@proxmox.com> <20220602112234.1868726-4-s.hrdlicka@proxmox.com> From: Matthias Heiserer In-Reply-To: <20220602112234.1868726-4-s.hrdlicka@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.347 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -2.575 Looks like a legit reply (A) SCC_BODY_URI_ONLY 1.596 - SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [github.io] Subject: Re: [pve-devel] [PATCH pve-docs 3/3] fix #3967: add ZFS dRAID documentation X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Jun 2022 12:47:31 -0000 I found a few typos :) 8<--- > +ZFS dRAID > +~~~~~~~~~ > + > +In a ZFS dRAID (declustered RAID) the hot spare drive(s) participate in the RAID. > +Their spare capacity is reservered and used for rebuilding when one drive fails. typo: reservered -> reserved > +This provides depending on the configuration faster rebuilding compaired to a Sounds a bit off to me. Maybe something like "Depending on the configuration, this provides..." would be better? > +RAIDZ in case of drive failure. More information can be found in the official > +openZFS documenation. footnote:[OpenZFS dRAID typo: documenation -> documentation > +https://openzfs.github.io/openzfs-docs/Basic%20Concepts/dRAID%20Howto.html] > + > +NOTE: dRAID is intended for more then 10-15 disks in a dRAID. A RAIDZ > +setup should be better for a lower amount of disks in most use cases. > + > + * `dRAID1` or `dRAID`: requires at least 2 disks, one can fail before data is > +lost > + * `dRAID2`: requires at least 3 disks, two can fail before data is lost > + * `dRAID3`: requires at least 4 disks, three can fail before data is lost > + > + > +Additonal information can be found on manual page: typo: Additional > + > +---- > +# man zpoolconcepts > +---- > + > +spares and data I think we consistently start headers with a capital letter, so "spares" should be "Spares" > +^^^^^^^^^^^^^^^ > +The number of `spares` tells the system how many disks it should keep ready in > +case of of a disk failure. The default value is 0 `spares`. Without spares typo: of of -> of > +rebuilding won't get any speed benefits. > + > +The number of `data` devices specifies the size of a parity group. The default > +is 8 if the number of `disks - parity - spares >= 8`. A higher number of `data` > +and parity drives increases the allocation size (e.g. for 4k sectors with > +default `data`=6 minimum allocation size is 24k) which can affect compression. > + > + > Bootloader > ~~~~~~~~~~ >