From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9A6B8981A4 for ; Fri, 6 Oct 2023 15:16:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 83DB3C09 for ; Fri, 6 Oct 2023 15:16:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 6 Oct 2023 15:16:32 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CF96F44871 for ; Fri, 6 Oct 2023 15:16:31 +0200 (CEST) Message-ID: <5bca3155-3fc9-4f80-878a-31c4369d20c3@proxmox.com> Date: Fri, 6 Oct 2023 15:16:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Lukas Wagner To: Proxmox VE development discussion , Philipp Hufnagl References: <20230922143658.1639173-1-p.hufnagl@proxmox.com> <20230922143658.1639173-5-p.hufnagl@proxmox.com> Content-Language: de-AT, en-US In-Reply-To: <20230922143658.1639173-5-p.hufnagl@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.178 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH proxmox-widget-toolkit v1 2/2] fix #4546: utils: save expiring date of user account for UI X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Oct 2023 13:16:32 -0000 Comments inline. On 9/22/23 16:36, Philipp Hufnagl wrote: > When an user experation date is send with the /accesss/tickets POST API ^ ^ ^ some minor typos: expiration sent access > call, it will be stored in a global variable like the username > > Signed-off-by: Philipp Hufnagl > --- (...) > diff --git a/src/Utils.js b/src/Utils.js > index a7ded2a..5481a32 100644 > --- a/src/Utils.js > +++ b/src/Utils.js > @@ -309,6 +309,9 @@ utilities: { > > setAuthData: function(data) { > Proxmox.UserName = data.username; > + if (data.user_expieres !== '') { Shouldn't this be !== null? So maybe just do a if (data['account-expiry-date']) { ... } > + Proxmox.UserExpires = data.user_expieres; typo, and same general remark regarding the naming as in the `access-control` patch.> + } > Proxmox.LoggedOut = data.LoggedOut; > // creates a session cookie (expire = null) > // that way the cookie gets deleted after the browser window is closed Also, the CSS changes found in this commit should probably be in another commit. Furthermore, I'd probably send the widget-toolkit patches before the pve-manager patches, since you require the `Proxmox.UserExpires` variable to be set in your changes for `pve-manager`. -- - Lukas