From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 15D5C6166C for ; Thu, 3 Dec 2020 16:35:50 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1370C2C5F9 for ; Thu, 3 Dec 2020 16:35:50 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EE4EC2C5EA for ; Thu, 3 Dec 2020 16:35:48 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BA5F9440DE for ; Thu, 3 Dec 2020 16:35:48 +0100 (CET) To: Proxmox VE development discussion , Dominik Csapak References: <20201203150140.15040-1-d.csapak@proxmox.com> From: Aaron Lauterer Message-ID: <5b89c12c-ce1b-cf57-337c-4ca7b333c2cd@proxmox.com> Date: Thu, 3 Dec 2020 16:35:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <20201203150140.15040-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.004 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [pvestatd.pm] Subject: Re: [pve-devel] [PATCH manager] pvestatd: fix container cpuset scheduling X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2020 15:35:50 -0000 Tested-By: Aaron Lauterer On 12/3/20 4:01 PM, Dominik Csapak wrote: > Since pve-container commit > > c48a25452dccca37b3915e49b7618f6880aeafb1 > > the code to get the cpuset controller path lives in pve-commons PVE::CGroup. > Use that and improve the logging in case some error happens in the future. > Such an error will only be logged once per pvestatd run, > so it does not spam the log. > > Signed-off-by: Dominik Csapak > --- > PVE/Service/pvestatd.pm | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm > index 5e533ca3..7193388c 100755 > --- a/PVE/Service/pvestatd.pm > +++ b/PVE/Service/pvestatd.pm > @@ -20,7 +20,7 @@ use PVE::Storage; > use PVE::QemuServer; > use PVE::QemuServer::Monitor; > use PVE::LXC; > -use PVE::LXC::CGroup; > +use PVE::CGroup; > use PVE::LXC::Config; > use PVE::RPCEnvironment; > use PVE::API2::Subscription; > @@ -257,7 +257,11 @@ my $NO_REBALANCE; > sub rebalance_lxc_containers { > # Make sure we can find the cpuset controller path: > return if $NO_REBALANCE; > - my $cpuset_base = eval { PVE::LXC::CGroup::cpuset_controller_path() }; > + my $cpuset_base = eval { PVE::CGroup::cpuset_controller_path() }; > + if (my $err = $@) { > + syslog('info', "could not get cpuset controller path: $err"); > + } > + > if (!defined($cpuset_base)) { > $NO_REBALANCE = 1; > return; >