From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path:
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 812299BCE1
for ; Tue, 21 Nov 2023 14:13:19 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 6674E9D44
for ; Tue, 21 Nov 2023 14:12:49 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for ; Tue, 21 Nov 2023 14:12:48 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A6F2341572
for ; Tue, 21 Nov 2023 14:12:48 +0100 (CET)
Message-ID: <5a481b10-f39f-4795-9442-fbc4511d17be@proxmox.com>
Date: Tue, 21 Nov 2023 14:12:47 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: Christian Ebner ,
Proxmox VE development discussion
References: <20231116103547.47205-1-p.hufnagl@proxmox.com>
<1559158275.496.1700569001810@webmail.proxmox.com>
From: Philipp Hufnagl
In-Reply-To: <1559158275.496.1700569001810@webmail.proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.051 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
Subject: Re: [pve-devel] [PATCH storage v3 0/4] pbs: fix #5008: Prevent
adding pbs storage with invalid namespace
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
X-List-Received-Date: Tue, 21 Nov 2023 13:13:19 -0000
On 11/21/23 13:16, Christian Ebner wrote:
>> On 16.11.2023 11:35 CET Philipp Hufnagl wrote:
>>
>>
>> Currently, when adding a PBS storage with a namespace that does not
>> exist, the storage gets added normally, but browsing/using it only
>> returns a cryptic error message.
>>
>> This change checks if the namespace entered when adding is valid and
>> prompts an error if it is not. If no namespace is provided, the storage
>> will be added without error.
>>
>> This is done by adding code to check if the namespace exists and call it
>> as well as existing code to check if a datastore exists on the add and
>> update hooks of the PBS datastore.
>>
>> Signed-off-by: Philipp Hufnagl
>> ---
>>
>> Changes since v2:
>> * Typos
>> * reuse connecton on one more place previously fortotten
>> * simplify syntax
>>
>> Changes since v1:
>> * do not add any overhead to activate_storage calls
>> * splits code from activate_storage so parts of it can be reused
>> * adds new methods to check namespaces
>> * calls checks on add/update hooks
>>
>> Philipp Hufnagl (4):
>> pbs: Move pbs_api_connect earlyer in the code
>> pbs: Make it possible to reuse PBS connection for datastore API call
>> pbs: Extraxt check_datastore_exists from activate_storage
>> pbs: fix #5008: Check if datastore and namespace is valid on add- and
>> update hooks
>>
>> src/PVE/Storage/PBSPlugin.pm | 122 ++++++++++++++++++++++++-----------
>> 1 file changed, 84 insertions(+), 38 deletions(-)
>>
>> --
>> 2.39.2
>
> Something is still broken, while testing with your patches applied I am not able to edit an existing PBS storage backend.
>
> When I try to e.g. disable the storage via the WebUI I get the following error:
> `update storage failed: PBS-local: Cannot find datastore '', check permissions and existence! (500)`
> Without your patches applied everything works as expected again.
>
> Cheers,
> Chris
Hmmm... thats very curios. I tried that on my end and it worked fine.
What datastore did you try to delete? Did you have a valid
configuration for it?